[Core] Transition changes geometrical object bins, add PointIsInsideBoundingBox functionality
#11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roigcarlo
approved these changes
Oct 16, 2023
| @@ -79,8 +79,8 @@ class KRATOS_API(KRATOS_CORE) GeometricalObjectsBins | |||
| for (TIteratorType i_object = GeometricalObjectsBegin ; i_object != GeometricalObjectsEnd ; i_object++){ | |||
| mBoundingBox.Extend(i_object->GetGeometry().begin() , i_object->GetGeometry().end()); | |||
| } | |||
| mBoundingBox.Extend(Tolerance); | |||
There was a problem hiding this comment.
Shouldn't the default tolerance of this function be std::numeric_limits<double>::epsilon() instead of 1e-12 then?
Edit: The function on which this line is being called, github didnt let me ping the header.
Aside from that all ok. I approve because its just a question.
There was a problem hiding this comment.
It is the current tolerance, better don't touch to avoid break things
loumalouomega
deleted the
core/minor-transition-changes-geometrical-object-bins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces new functionality to the
GeometricalObjectsBinsclass. Here are the key changes made:bool GeometricalObjectsBins::PointIsInsideBoundingBox(const array_1d<double,3>& rCoords)that checks if a point is inside the bounding box of geometrical objects.bool GeometricalObjectsBins::PointIsInsideBoundingBoxWithTolerance(const array_1d<double,3>& rCoords)that checks if a point is inside the bounding box with tolerance.GeometricalObjectsBins::CalculateCellSizefunction to include additional logic.test_geometrical_objects_bins.cpp.These changes seem to be aimed at improving the functionality of the
GeometricalObjectsBinsclass by adding methods to check if a point lies within the bounding box of geometrical objects, with and without tolerance. The changes also include updates to test cases to ensure the new functionality works as expected.🆕 Changelog