Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Added reading missing parameters for the solving strategy #11693

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[GeoMechanicsApplication] Added reading missing parameters for the solving strategy #11693

merged 2 commits into from
Oct 18, 2023

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Oct 18, 2023

This PR aims to add reading more parameters for the solving strategy from the parameters json format including:

  1. The move_mesh_flag
  2. The reform_dofs_at_each_step flag
  3. The compute_reactions flag
  4. The max_iterations

@rfaasse rfaasse added the GeoMechanics Issues related to the GeoMechanicsApplication label Oct 18, 2023
@rfaasse rfaasse requested a review from avdg81 October 18, 2023 08:43
avdg81
avdg81 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only have one minor suggestion and two replies to your own comments.

applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_solving_strategy_factory.cpp Show resolved Hide resolved
@rfaasse @avdg81
Processing review comment
d749473 
Co-authored-by: Anne van de Graaf <[email protected]>
@rfaasse rfaasse requested a review from avdg81 October 18, 2023 14:55
avdg81
avdg81 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

@avdg81 avdg81 merged commit 7d42c57 into master Oct 18, 2023
@avdg81 avdg81 deleted the geo/read-missing-strategy-parameters branch October 18, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdg81 avdg81 avdg81 approved these changes

Assignees
No one assigned
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfaasse @avdg81