-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Add method to time loop executor to cancel the loop #11727
[GeoMechanicsApplication] Add method to time loop executor to cancel the loop #11727
Conversation
Just pointing you to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clear, thanks for adding this! I just had an idea to make it a little bit cleaner (very minor change) after that, we're good to go!
applications/GeoMechanicsApplication/custom_workflows/time_loop_executor.hpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_workflows/time_loop_executor.hpp
Outdated
Show resolved
Hide resolved
Thanks @rubenzorrilla for pointing to this interface, that's a good suggestion! The only issue here is that it is required to be able to define this function outside of the C++ code through a C-interface, so unfortunately we cannot use the Controller here. |
📝 Description
Implement the unused rShouldCancel delegate, by setting it on the time loop executor we can cancel runs while they are ongoing