Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Add method to time loop executor to cancel the loop #11727

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

carloslubbers
Copy link
Contributor

📝 Description
Implement the unused rShouldCancel delegate, by setting it on the time loop executor we can cancel runs while they are ongoing

@carloslubbers carloslubbers added the GeoMechanics Issues related to the GeoMechanicsApplication label Oct 26, 2023
@rubenzorrilla
Copy link
Member

Just pointing you to Controller class (see here). I think it might be useful for this kind of purpose.

@carloslubbers carloslubbers requested a review from rfaasse November 8, 2023 09:16
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear, thanks for adding this! I just had an idea to make it a little bit cleaner (very minor change) after that, we're good to go!

@rfaasse
Copy link
Contributor

rfaasse commented Nov 14, 2023

Just pointing you to Controller class (see here). I think it might be useful for this kind of purpose.

Thanks @rubenzorrilla for pointing to this interface, that's a good suggestion! The only issue here is that it is required to be able to define this function outside of the C++ code through a C-interface, so unfortunately we cannot use the Controller here.

@carloslubbers carloslubbers merged commit e6eb1f8 into master Nov 14, 2023
@carloslubbers carloslubbers deleted the geo/Add-cancel-delegate-to-settlement-workflow branch November 14, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants