[GeoMechanicsApplication] Add line_search support to solving_strategy_factory #11814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloslubbers
added
the
GeoMechanics
carloslubbers
changed the title
…on. Unit and integration test added.
rfaasse
reviewed
Nov 22, 2023
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_solving_strategy_factory.cpp
Show resolved
Hide resolved
...tions/GeoMechanicsApplication/tests/test_settlement_workflow/test_model_stage4.post.orig.res
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| return nullptr; | ||
| } | ||
|
|
||
| private: | ||
| static Parameters ExtractStrategyParameters(const Parameters &rSolverSettings) | ||
| { | ||
| static Parameters ExtractStrategyParameters(const Parameters &rSolverSettings, |
There was a problem hiding this comment.
I need a similar function in the criteria factory, I think I'll extract it there into some helper/utility function
rfaasse
approved these changes
Nov 23, 2023
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_utilities/solving_strategy_factory.hpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Allows line_search solving strategy to be used through the geomechanics c++ interface