[GeoMechanicsAnalysis] separated start of code cleaning U Pw diff order element #11820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntal linear material
WPK4FEM
added
Refactor
rfaasse
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Thanks for splitting this part out of the other PR, this makes it easier to see what's going on and thanks for incorporating the comments. I still see room for improvement within the files, but I think this is a very nice first step in cleaning this class up.
I have just one question left about changes to a part which might not be sufficiently tested. Other than that, this is ready to be merged
applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp
Show resolved
Hide resolved
Comment on lines
+584
to
+597
| for ( SizeType i = 0; i < NumUNodes; ++i ) { | ||
| rResult[Index] = rGeom[i].GetDof( DISPLACEMENT_X ).EquationId(); | ||
| ++Index; | ||
| rResult[Index] = rGeom[i].GetDof( DISPLACEMENT_Y ).EquationId(); | ||
| ++Index; | ||
| if (Dim > 2) { | ||
| rResult[Index] = rGeom[i].GetDof( DISPLACEMENT_Z ).EquationId(); | ||
| ++Index; | ||
| } | ||
| } | ||
| for ( SizeType i = 0; i < NumPNodes; ++i ){ | ||
| rResult[Index] = rGeom[i].GetDof( WATER_PRESSURE ).EquationId(); | ||
| ++Index; | ||
| } |
There was a problem hiding this comment.
I like the improvement in this part, let's keep in mind for a next PR that we can extract a function here, since it seems identical for velocity and acceleration
rfaasse
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Start of reducing code smells in U Pw diff order element
Has been split of from the incremental linear material where this accidentally was included.
SonarCloud now shows 0 codesmells on this.