-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Cleaning the DisplacementCriteria
and ResidualCriteria
and adding tests
#11822
Merged
loumalouomega
merged 11 commits into
master
from
core/cleaning-and-testing-displacement-residual-criteria
Nov 20, 2023
Merged
[Core] Cleaning the DisplacementCriteria
and ResidualCriteria
and adding tests
#11822
loumalouomega
merged 11 commits into
master
from
core/cleaning-and-testing-displacement-residual-criteria
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
added
Kratos Core
Testing
Parallel-SMP
Shared memory parallelism with OpenMP or C++ Threads
FastPR
This Pr is simple and / or has been already tested and the revision should be fast
Transition
labels
Nov 17, 2023
roigcarlo
reviewed
Nov 20, 2023
kratos/solving_strategies/convergencecriterias/displacement_criteria.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/convergencecriterias/residual_criteria.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/convergencecriterias/residual_criteria.h
Outdated
Show resolved
Hide resolved
Done @roigcarlo |
roigcarlo
approved these changes
Nov 20, 2023
loumalouomega
deleted the
core/cleaning-and-testing-displacement-residual-criteria
branch
November 20, 2023 15:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FastPR
This Pr is simple and / or has been already tested and the revision should be fast
Kratos Core
Parallel-SMP
Shared memory parallelism with OpenMP or C++ Threads
Testing
Transition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The following PR cleans up the
DisplacementCriteria
andResidualCriteria
and adding tests, in summary:In the file "kratos/solving_strategies/convergencecriterias/displacement_criteria.h":
In the file "kratos/solving_strategies/convergencecriterias/residual_criteria.h":
🆕 Changelog
DisplacementCriteria
andResidualCriteria
DisplacementCriteria
andResidualCriteria
DisplacementCriteria
andResidualCriteria