Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Cleaning the DisplacementCriteria and ResidualCriteria and adding tests #11822

Merged

Conversation

loumalouomega
Copy link
Member

📝 Description

The following PR cleans up the DisplacementCriteria and ResidualCriteria and adding tests, in summary:

  1. In the file "kratos/solving_strategies/convergencecriterias/displacement_criteria.h":

    • Improved documentation and comments.
    • Updated type definitions and member variables.
    • Using parallel utilities.
    • Adding C++ test.
  2. In the file "kratos/solving_strategies/convergencecriterias/residual_criteria.h":

    • Updated type definitions and comments.
    • Improved documentation and comments.
    • Using parallel utilities.
    • Adding C++ test.

🆕 Changelog

@loumalouomega loumalouomega added Kratos Core Testing Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads FastPR This Pr is simple and / or has been already tested and the revision should be fast Transition labels Nov 17, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner November 17, 2023 14:54
@loumalouomega
Copy link
Member Author

@roigcarlo

@loumalouomega
Copy link
Member Author

Done @roigcarlo

@loumalouomega loumalouomega merged commit 9f70a91 into master Nov 20, 2023
@loumalouomega loumalouomega deleted the core/cleaning-and-testing-displacement-residual-criteria branch November 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads Testing Transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants