[Fluid] Fixing uninitialized value in alternative_d_vms_dem_coupled element #11828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applications/FluidDynamicsApplication/custom_elements/alternative_d_vms_dem_coupled.cpp
Outdated
Show resolved
Hide resolved
…ive_d_vms_dem_coupled.cpp Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
|
Ok, I forgot to inititialize it |
|
can you approve it then @jgonzalezusua ? |
loumalouomega
approved these changes
Nov 20, 2023
Sure! |
jgonzalezusua
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
One of the test from fluid dynamics app was failing in @KratosMultiphysics/altair CI, it seems it was because mPredictedSubscaleVelocity was being used without being initialized. I think this fixes the problem.