Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Adding rotational dofs (conditionally) for block builder and solver #11907

Merged
merged 5 commits into from
Dec 21, 2023
Merged

[GeoMechanicsApplication] Adding rotational dofs (conditionally) for block builder and solver #11907

merged 5 commits into from
Dec 21, 2023

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Dec 21, 2023 •
edited
Loading

📝 Description
This PR adds rotational dofs to getting the first/second time derivatives in the ResidualBasedBlockBuilderAndSolverWithMassAndDamping class and adds a regression test.

@rfaasse rfaasse added the GeoMechanics Issues related to the GeoMechanicsApplication label Dec 21, 2023
@rfaasse rfaasse marked this pull request as ready for review December 21, 2023 10:35
aronnoordam
aronnoordam previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@aronnoordam aronnoordam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aronnoordam
Copy link
Member

#11891

@aronnoordam aronnoordam linked an issue Dec 21, 2023 that may be closed by this pull request
[GeoMechanicsApplication] Rotation DOFS are not added in residualbased_block_builder_and_solver_with_mass_and_damping.h #11892
Closed
WPK4FEM
WPK4FEM previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vector sizing and initialization is changed as discussed. Thank you.

@rfaasse rfaasse enabled auto-merge (squash) December 21, 2023 13:48
avdg81
avdg81 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice and clean improvement Richard!

@rfaasse rfaasse disabled auto-merge December 21, 2023 13:52
@rfaasse rfaasse enabled auto-merge (squash) December 21, 2023 15:14
@rfaasse rfaasse merged commit c7c5b44 into master Dec 21, 2023
17 checks passed
@rfaasse rfaasse deleted the geo/add-rotational-dofs branch December 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdg81 avdg81 avdg81 approved these changes

@WPK4FEM WPK4FEM WPK4FEM left review comments

@aronnoordam aronnoordam aronnoordam left review comments

Assignees
No one assigned
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Milestone
No milestone
4 participants
@rfaasse @aronnoordam @avdg81 @WPK4FEM