Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Fix for prescribed displacement combined with reset_displacement. #11933

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

WPK4FEM
Copy link
Contributor

@WPK4FEM WPK4FEM commented Jan 8, 2024

📝 Description
Override of method from analysis stage implemented in geomechanics analysis, such that the reset_displacment resetting of the displacement and rotation field is done before the proces for prescribed displacements and rotations.
Regression test added.

@WPK4FEM WPK4FEM self-assigned this Jan 8, 2024
@WPK4FEM WPK4FEM requested review from avdg81 and mcgicjn2 January 8, 2024 14:53
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work done here. Just as a friendly reminder: the same issue also applies to our C++ workflow for settlement.

@WPK4FEM WPK4FEM force-pushed the geo/reset_displacement_with_Dirichlet_condition branch from 8be98b9 to c683d53 Compare January 9, 2024 16:21
@WPK4FEM WPK4FEM force-pushed the geo/reset_displacement_with_Dirichlet_condition branch from c683d53 to 01d678b Compare January 10, 2024 14:47
@WPK4FEM WPK4FEM requested review from avdg81 and rfaasse January 11, 2024 07:58
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix with a clear test!

@WPK4FEM WPK4FEM merged commit 337508f into master Jan 11, 2024
17 checks passed
@WPK4FEM WPK4FEM deleted the geo/reset_displacement_with_Dirichlet_condition branch January 11, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Fix Dirichlet conditions i.c.w. reset_displacement
3 participants