Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exps] Remove container type and use Globals::DataLocation #11989

Merged
merged 6 commits into from
Feb 2, 2024
Merged

[Exps] Remove container type and use Globals::DataLocation #11989

merged 6 commits into from
Feb 2, 2024

Conversation

sunethwarna
Copy link
Member

📝 Description
This PR removes all the use cases of Traits::ContainerType and replaces it with the Globals::DataLocation.

🆕 Changelog

  • Replaces Traits::ContainerType with Globals::DataLocation
  • Updated tests.

@sunethwarna sunethwarna self-assigned this Jan 27, 2024
@sunethwarna sunethwarna requested a review from a team as a code owner January 27, 2024 08:47
@sunethwarna sunethwarna merged commit ede8e34 into core/exp/nodal_expression_io/name_change Feb 2, 2024
17 checks passed
@sunethwarna sunethwarna deleted the core/exps/remove_container_type branch February 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matekelemen matekelemen matekelemen approved these changes

Assignees

@sunethwarna sunethwarna

@matekelemen matekelemen

Labels
C++ Kratos Core Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunethwarna @matekelemen