[GeoMechanicsApplication] Removed a redundant C++ unit test wrapper #12033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed test script `test_normal_flux_condition.py`, which executed two C++ unit tests: `TestCalculateHorizontalNormalFlux` and `TestCalculateInclinedNormalFlux`. These unit tests, however, are also executed through test script `run_cpp_tests.py`, since both are part of test suite `KratosGeoMechanicsFastSuite`. As such, the former test script was redundant and it has been removed now. A few other changes were carried out to address three code smells reported by SonarQube and some problems detected by Clang-tidy.
avdg81
added
Cleanup
Testing
GeoMechanics
markelov208
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Removed test script
test_normal_flux_condition.py, which executed two C++ unit tests:TestCalculateHorizontalNormalFluxandTestCalculateInclinedNormalFlux. These unit tests, however, are also executed through test scriptrun_cpp_tests.py, since both are part of test suiteKratosGeoMechanicsFastSuite. As such, the former test script was redundant and it has been removed now.A few other changes were carried out to address three code smells reported by SonarQube and some problems detected by Clang-tidy.