Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptApp] Fixing the NLOPT algorithms #12039

Merged
merged 3 commits into from
Feb 12, 2024
Merged

[OptApp] Fixing the NLOPT algorithms #12039

merged 3 commits into from
Feb 12, 2024

Conversation

Igarizza
Copy link
Member

@Igarizza Igarizza commented Feb 9, 2024

📝 Description
Due to some interfaces changes this method is required to be fixed. The PR brings the fixes and allows to use the lib again.

🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.

  • Added feature X to Y
  • Added Foo Application
  • Fixed X (#XXXX Reference to issue if apply)
  • etc...

@Igarizza Igarizza requested a review from sunethwarna February 9, 2024 10:37
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

Comment on lines 4 to 6
"parallel_type": "OpenMP",
"start_time": 0.0,
"end_time": 1.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not required in opt analysis.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Igarizza Igarizza merged commit 583fb45 into master Feb 12, 2024
15 of 17 checks passed
@Igarizza Igarizza deleted the optapp/fix-nag branch February 12, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants