[GeoMechanicsApplication] Revisit test_absorbing_boundary.py #12053

markelov208 · 2024-02-12T16:33:29Z

📝 Description
The goal is to understand what these tests do and to document that.

🆕 Changelog
ReadMe.md files are added.
'test_' was removed from folders and files' names.
test_absorbing_boundary.py is renamed as absorbing_boundary.py

- ReadMe.md files are added. - 'test_' was removed from folders and files' names. - test_absorbing_boundary.py is renamed as absorbing_boundary.py

WPK4FEM

Hi Gennady,
Good work. Some remarks on units and the roller boundary representation in the pictures.
Thank you,
Wijtze Pieter

WPK4FEM · 2024-02-13T09:53:08Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

@@ -0,0 +1,34 @@
+# Lysmer absorbing boundary conditions on a column made of rectangulars


It is more common to use quadrilaterals ( i.s.o rectangulars ) See also line 7.

The remarks on this README.md file can be repeated for the other README.md file.

Thank you. Indeed it is more consistent with the code.

WPK4FEM · 2024-02-13T09:56:55Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+The test is performed for an 1D column that is made with 2D rectangular elements. The column height and width are 10,000 mm and 1,000 m, respectively.
+The column consists of ten 4-noded elements (using the UPwSmallStrainElement2D4N class) of 1,000mm x 1,000 mm. A
+schematic representation can be found in the figure below:


I guess the test in in m rather than mm.
Here a comma is used as separator for the numbers. Lines 23 - 26 use a dot. Or am I mistaking separators for thousands and decimals?

Yes, in m. The values are fixed and notations. It was not a good idea to use a coma as a separator for thousands.

WPK4FEM · 2024-02-13T09:58:57Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+
+All Nodes have fixed displacement in the X direction. 
+
+An instant load of -10 N is applied in the Y direction at the column top that is defined by Nodes 1 and 2. 


The .mdpa file and the picture show a line load. Therefore I expect units of Force / length and mentioning the top edge i.s.o. nodes.

Currently, I put N/m2 to be consistent with the equations.

WPK4FEM · 2024-02-13T09:59:16Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+
+The material is described using:
+
+-   A linear elastic plane stress model (LinearElasticPlaneStrain2DLaw),


plane strain model i.s.o plane stress model.

Thank you. Now it is strain.

WPK4FEM · 2024-02-13T10:00:33Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+-   Young's modulus is 10,000 N/mm2
+-   Poisson's ratio is 0.2,
+-   A thickness of 1 mm,
+-   Density of solid is 2.65 kg/mm3,


2.65 for soil density makes me think that the unit of mass is ton, the unit of length is m and the corresponding unit of force is kN.

Changed kg => ton and put kN/m2 for the Young's module. Hope the value is consistent with data for sand.

WPK4FEM · 2024-02-13T10:06:36Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/MeshStructure.svg

@@ -0,0 +1,3382 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>


Very nice pictures!

The roller conditions are placed exactly on the top nodes. By convention that would mean that they only apply to that node. To let them apply for an entire edge, it is common to place them on an edge ( not exactly on a node ) and repeat that once or twice further along the edge

This remark is similar for the other picture.

Moved rollers and added more of them.

rfaasse

Very clear documentation with easy to understand schematics! I have a few suggestions on improvements (mainly to have even less need to look into the json files or python test file by adding some more info to the documentation).

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

applications/GeoMechanicsApplication/tests/lysmer_boundary_stiff_column2d_quad/README.md

markelov208

Wijtze-Pieter and Richard, many thanks for the quick and detailed review. Hope the modifications resolve all your comments.

applications/GeoMechanicsApplication/tests/lysmer_boundary_stiff_column2d_quad/README.md

markelov208 · 2024-02-13T12:01:07Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

@@ -0,0 +1,34 @@
+# Lysmer absorbing boundary conditions on a column made of rectangulars


Thank you. Indeed it is more consistent with the code.

markelov208 · 2024-02-13T12:02:40Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+The test is performed for an 1D column that is made with 2D rectangular elements. The column height and width are 10,000 mm and 1,000 m, respectively.
+The column consists of ten 4-noded elements (using the UPwSmallStrainElement2D4N class) of 1,000mm x 1,000 mm. A
+schematic representation can be found in the figure below:


Yes, in m. The values are fixed and notations. It was not a good idea to use a coma as a separator for thousands.

markelov208 · 2024-02-13T12:03:47Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+
+All Nodes have fixed displacement in the X direction. 
+
+An instant load of -10 N is applied in the Y direction at the column top that is defined by Nodes 1 and 2. 


Currently, I put N/m2 to be consistent with the equations.

markelov208 · 2024-02-13T12:04:13Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+
+The material is described using:
+
+-   A linear elastic plane stress model (LinearElasticPlaneStrain2DLaw),


Thank you. Now it is strain.

markelov208 · 2024-02-13T12:05:24Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+-   Young's modulus is 10,000 N/mm2
+-   Poisson's ratio is 0.2,
+-   A thickness of 1 mm,
+-   Density of solid is 2.65 kg/mm3,


Changed kg => ton and put kN/m2 for the Young's module. Hope the value is consistent with data for sand.

markelov208 · 2024-02-13T12:05:49Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/MeshStructure.svg

@@ -0,0 +1,3382 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>


Moved rollers and added more of them.

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

applications/GeoMechanicsApplication/tests/lysmer_boundary_stiff_column2d_quad/README.md

rfaasse

Looks good from my point of view. Thanks for incorporating the changes! (I have one more conceptual question left, but that's not blocking)

WPK4FEM

Dear Gennady,
Thank you for all the revision work. Now the pictures look even better.
One remark about the thickness. the unit triggered the remark, but in plane strain there is no need to mention thickness as it is unity by convention.

WPK4FEM · 2024-02-13T12:46:46Z

applications/GeoMechanicsApplication/tests/lysmer_boundary_column2d_quad/README.md

+-   A linear elastic plane strain model (LinearElasticPlaneStrain2DLaw),
+-   Young's modulus is $E$=10000 $kN/m^2$
+-   Poisson's ratio is $\nu$=0.2,
+-   A thickness of 1 $mm$,


Also here length unit m, but it is a plane strain model. Plane strain models always have unit thickness, so I think it is better to remove line 24 and the corresponding line in the other test.

Removed the lines

WPK4FEM

Thank you, now I think it is complete.

Gennady Markelov added 2 commits February 12, 2024 16:37

updated two tests for Lysmer absorbing boundary

fff6a6e

- ReadMe.md files are added. - 'test_' was removed from folders and files' names. - test_absorbing_boundary.py is renamed as absorbing_boundary.py

updated MeshStructure files

9cca007

markelov208 self-assigned this Feb 12, 2024

changed test_absorbing_boundary onto absorbing_boundary

eb4535a

markelov208 requested review from rfaasse and WPK4FEM February 13, 2024 09:23

WPK4FEM reviewed Feb 13, 2024

View reviewed changes

Merge branch 'master' into geo/12051-revisit-test-absorbing-boundary

fe93393

rfaasse reviewed Feb 13, 2024

View reviewed changes

Gennady Markelov added 2 commits February 13, 2024 12:22

modifications following the review comments

6f11e81

modification of the equations

5e73bf8

markelov208 commented Feb 13, 2024

View reviewed changes

WPK4FEM linked an issue Feb 13, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Revisit test_absorbing_boundary.py #12051

Closed

rfaasse previously approved these changes Feb 13, 2024

View reviewed changes

WPK4FEM reviewed Feb 13, 2024

View reviewed changes

removed thickness

50ba98e

markelov208 dismissed rfaasse’s stale review via 50ba98e February 13, 2024 12:53

WPK4FEM approved these changes Feb 13, 2024

View reviewed changes

rfaasse approved these changes Feb 13, 2024

View reviewed changes

markelov208 merged commit 45000df into master Feb 13, 2024
15 of 17 checks passed

markelov208 deleted the geo/12051-revisit-test-absorbing-boundary branch February 13, 2024 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Revisit test_absorbing_boundary.py #12053

[GeoMechanicsApplication] Revisit test_absorbing_boundary.py #12053

markelov208 commented Feb 12, 2024

WPK4FEM left a comment

WPK4FEM Feb 13, 2024

markelov208 Feb 13, 2024

WPK4FEM Feb 13, 2024

markelov208 Feb 13, 2024

WPK4FEM Feb 13, 2024

markelov208 Feb 13, 2024

WPK4FEM Feb 13, 2024

markelov208 Feb 13, 2024

WPK4FEM Feb 13, 2024

markelov208 Feb 13, 2024

WPK4FEM Feb 13, 2024

markelov208 Feb 13, 2024

rfaasse left a comment

markelov208 left a comment

markelov208 Feb 13, 2024

markelov208 Feb 13, 2024

markelov208 Feb 13, 2024

markelov208 Feb 13, 2024

markelov208 Feb 13, 2024

markelov208 Feb 13, 2024

rfaasse left a comment

WPK4FEM left a comment

WPK4FEM Feb 13, 2024

markelov208 Feb 13, 2024

WPK4FEM left a comment

		@@ -0,0 +1,34 @@
		# Lysmer absorbing boundary conditions on a column made of rectangulars


		All Nodes have fixed displacement in the X direction.

		An instant load of -10 N is applied in the Y direction at the column top that is defined by Nodes 1 and 2.


		The material is described using:

		- A linear elastic plane stress model (LinearElasticPlaneStrain2DLaw),

		@@ -0,0 +1,3382 @@
		<?xml version="1.0" encoding="UTF-8" standalone="no"?>

[GeoMechanicsApplication] Revisit test_absorbing_boundary.py #12053

[GeoMechanicsApplication] Revisit test_absorbing_boundary.py #12053

Conversation

markelov208 commented Feb 12, 2024

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment