-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FastPR][Core] Missing Tetrahedra3D10 second derivatives #12082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test
These are not tested in any geometry. Also note that there is nothing to test in here, values are hardcoded... |
Most geometries are linear, therefore this is not even existing
In that case test should be easy... |
I checked it for the quadratic ones featuring the implementation of this method.
Easy but meaningless... Anyway, I'll try to figure out something. |
You may have hardcoded wrong, that happened to me several times. In any case I will approve and I leave up to to you add the test or not. |
@loumalouomega rather than checking hardcoded values, which IMO makes no point at all, I decided to create a fake isoparametric tet (so we avoid the Jacobian transformation complexities) and check the derivatives values with a second order field, expected to be constant over the entire element. |
📝 Description
Adding the shape functions second derivatives to the
Tetrahedra3D10
geometry.