Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix core stub generation #12109

Merged
merged 7 commits into from
Feb 27, 2024
Merged

[Docs] Fix core stub generation #12109

merged 7 commits into from
Feb 27, 2024

Conversation

sunethwarna
Copy link
Member

📝 Description
Recently thestub generation started fail due to failure in linking shared libs. The implemented design with old mypy allowed to load cpp libs seperately and generate stubs while linking correctly. Recently, it started to fail with linking erros. This PR identifies all the cpp libs, and generte stubs with one command, so the mypy can link them correctly.

This fixes the segmentation fault in manjaro when LinearSolversApplication is compiled for stub generation.

This also adds the ability to add predefined stubs, if mypy fails to add special commands in the __init__.pyi.

🆕 Changelog

  • Fix stub generation

@sunethwarna sunethwarna self-assigned this Feb 25, 2024
@sunethwarna sunethwarna requested a review from a team as a code owner February 25, 2024 00:07
roigcarlo
roigcarlo previously approved these changes Feb 26, 2024
scripts/post_install/kratos__init__.pyi Show resolved Hide resolved
scripts/post_install/stub_generation.py Outdated Show resolved Hide resolved
scripts/post_install/stub_generation.py Outdated Show resolved Hide resolved
@sunethwarna sunethwarna merged commit 2897542 into master Feb 27, 2024
15 of 17 checks passed
@sunethwarna sunethwarna deleted the core/stub_generation/fix branch February 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants