Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Separate source/header in CheckSkinProcess #12134

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[Core] Separate source/header in CheckSkinProcess #12134

merged 2 commits into from
Mar 5, 2024

Conversation

loumalouomega
Copy link
Member

📝 Description

Separate source/header in CheckSkinProcess. Also optimize includes to reduce compilation time.

🆕 Changelog

@loumalouomega loumalouomega added Cleanup Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast Refactor When code is moved or rewrote keeping the same behavior Header/source refactor Move code from header only to header/source structure labels Mar 4, 2024
@loumalouomega loumalouomega requested a review from a team as a code owner March 4, 2024 11:20
@loumalouomega loumalouomega enabled auto-merge March 4, 2024 12:37
@loumalouomega loumalouomega merged commit 3ea3838 into master Mar 5, 2024
15 of 17 checks passed
@loumalouomega loumalouomega deleted the core/separate-header-source-CheckSkinProcess branch March 5, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddiezrod ddiezrod ddiezrod approved these changes

@roigcarlo roigcarlo Awaiting requested review from roigcarlo

@rubenzorrilla rubenzorrilla Awaiting requested review from rubenzorrilla

Assignees
No one assigned
Labels
Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast Header/source refactor Move code from header only to header/source structure Kratos Core Refactor When code is moved or rewrote keeping the same behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loumalouomega @ddiezrod