Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EigenSolversApplication #12139

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Remove EigenSolversApplication #12139

merged 2 commits into from
Mar 4, 2024

Conversation

philbucher
Copy link
Member

This application is pure legacy, it was renamed to LinearSolversApplication almost 4 years ago => #7182

It is an empty shell only existing for backward compatibility, with large deprecation warnings. IMO 4 years is enough for migrating :)

@philbucher philbucher added Cleanup Applications Deprecated FastPR This Pr is simple and / or has been already tested and the revision should be fast Leftover Something remaining from a previous PR that must be cleaned labels Mar 4, 2024
@philbucher philbucher requested a review from rubenzorrilla March 4, 2024 15:08
@philbucher philbucher requested a review from a team as a code owner March 4, 2024 15:08
@loumalouomega
Copy link
Member

Empty shell sound so deep, like a noir film of an alcoholic detective that previously was a notorious police inspector ...

Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last.

@philbucher
Copy link
Member Author

Once upon a time in Kratos ...

I feel so old having lived through the days of the ExternalSolversApplication xD

@philbucher philbucher enabled auto-merge March 4, 2024 15:34
@loumalouomega
Copy link
Member

Once upon a time in Kratos ...

I feel so old having lived through the days of the ExternalSolversApplication xD

https://www.youtube.com/watch?v=oHhgllqSKro&t=5s

@philbucher philbucher merged commit b9525ff into master Mar 4, 2024
17 of 19 checks passed
@philbucher philbucher deleted the remove-eigensolvers-app branch March 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Cleanup Deprecated FastPR This Pr is simple and / or has been already tested and the revision should be fast Leftover Something remaining from a previous PR that must be cleaned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants