ROM: Enabling Numpy Format for Including Phi into Psi #12177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rom_output_paramaters -> rom_output_parameters
SADPR
added
FastPR
RiccardoRossi
approved these changes
Mar 13, 2024
| N_nodes = len(galerkin_rom_parameters["nodal_modes"]) | ||
| N_Dofs = int(N_Dof_per_node*N_nodes) | ||
| N_Dofs_rom = galerkin_rom_parameters["rom_settings"]["number_of_rom_dofs"] | ||
| u = np.zeros((N_Dofs,N_Dofs_rom)) |
There was a problem hiding this comment.
np.empty ... anyhow you overwrite it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling Numpy Format for Including$\Phi$ into $\Psi$
Overview
This pull request introduces support for integrating the reduced order basis ($\Phi$ ) into the subspace of the left reduced order basis ($\Psi$ ) specifically when the basis format is numpy. This addition complements the existing functionality designed for JSON-formatted bases, enhancing our framework's adaptability to different data formats.
Additional Improvements
rom_analysis.py, improving code clarity and readability.This update enhances our computational framework by enabling the inclusion of numpy-formatted reduced order bases (Phi) into Psi's subspace.