[OptApp] Fix a bug in GradientProjection and Relaxed Gradient Projection algorihtms #12275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
added
Applications
Python
FastPR
Igarizza
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
@sunethwarna thank you for finding this bug. It is for sure wrong and strange eto have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Honetsly, I am not sure until now how these two algorithms worked.... :D... There was some magic happening I guess..
The tests were passing until now, and with the fix also because we only have one constraint in the tests. @Igarizza We need to add some tests to capture these bugs by adding a test with two constraints.
🆕 Changelog
GradientProjectionandRelaxedGradientProjection