-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RomApp] Testing (with) RomManager #12285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SADPR
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
So far we had been working in automating the construction of our ROMs using the RomManager, but were lacking a proper test for it. This PR is intended to provide it
Moreover, in this PR some of the tests have been convereted to be launched with the RomManager.
🆕 Changelog
This of course has some limitations, and sometimes the user should provide minimal inputs like the type of projection desired or the nodal unknown for the training which is by default
[DISPLACEMENT_X, DISPLACEMENT_Y]
refactored the
test_structural_rom.py
to use the RomManagerrefactored the
test_thermal_lspg_rom.py
to use the RomManagerAdded tests for the RomManager that check