Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RomApp] Testing (with) RomManager #12285

Merged
merged 16 commits into from
May 2, 2024
Merged

[RomApp] Testing (with) RomManager #12285

merged 16 commits into from
May 2, 2024

Conversation

Rbravo555
Copy link
Member

@Rbravo555 Rbravo555 commented Apr 16, 2024

📝 Description
So far we had been working in automating the construction of our ROMs using the RomManager, but were lacking a proper test for it. This PR is intended to provide it

Moreover, in this PR some of the tests have been convereted to be launched with the RomManager.

🆕 Changelog

  • The RomManager was provided with some default values, so that one can instantiate it as
rom_mananger = RomManager()
rom_mananger.Fit()

This of course has some limitations, and sometimes the user should provide minimal inputs like the type of projection desired or the nodal unknown for the training which is by default [DISPLACEMENT_X, DISPLACEMENT_Y]

  • refactored the test_structural_rom.py to use the RomManager

  • refactored the test_thermal_lspg_rom.py to use the RomManager

  • Added tests for the RomManager that check

    • that the defaults are being loaded
    • that the simulation is correctly orchestrated (structural)
    • that the files are created
    • the error raising

@Rbravo555 Rbravo555 marked this pull request as ready for review April 23, 2024 10:42
@Rbravo555 Rbravo555 requested a review from a team as a code owner April 23, 2024 10:42
@SADPR SADPR merged commit 1dff87c into master May 2, 2024
11 checks passed
@SADPR SADPR deleted the RomApp_AddRomManagerTest branch May 2, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants