[GeoMechanicsApplication] Incremental displacement variable, output and integration test. #12288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfaasse
reviewed
Apr 23, 2024
applications/GeoMechanicsApplication/custom_workflows/time_loop_executor.hpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/python_scripts/geomechanics_U_Pw_solver.py
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/python_scripts/geomechanics_analysis.py
Show resolved
Hide resolved
avdg81
reviewed
Apr 24, 2024
Comment on lines
64
to
68
| """ | ||
| Calculates incremental displacement | ||
| :param node: | ||
| :return: | ||
| """ |
There was a problem hiding this comment.
Feel free to remove these lines, since they have no added value in my opinion. The method's name tells it all.
Comment on lines
69
to
70
| incremental_displacement = node.GetSolutionStepValue(KratosMultiphysics.DISPLACEMENT, 0) - \ | ||
| node.GetSolutionStepValue(KratosMultiphysics.DISPLACEMENT, 1) |
There was a problem hiding this comment.
In general, I would try to avoid using the line continuation marker. You can do that as follows:
Suggested change
| incremental_displacement = node.GetSolutionStepValue(KratosMultiphysics.DISPLACEMENT, 0) - \ | |
| node.GetSolutionStepValue(KratosMultiphysics.DISPLACEMENT, 1) | |
| incremental_displacement = (node.GetSolutionStepValue(KratosMultiphysics.DISPLACEMENT, 0) - | |
| node.GetSolutionStepValue(KratosMultiphysics.DISPLACEMENT, 1)) |
Comment on lines
247
to
248
| p_node->GetSolutionStepValue(DISPLACEMENT,1) = displacement_start_time_step; | ||
| p_node->GetSolutionStepValue(DISPLACEMENT,0) = displacement_end_time_step; |
There was a problem hiding this comment.
Nitpicking:
Suggested change
| p_node->GetSolutionStepValue(DISPLACEMENT,1) = displacement_start_time_step; | |
| p_node->GetSolutionStepValue(DISPLACEMENT,0) = displacement_end_time_step; | |
| p_node->GetSolutionStepValue(DISPLACEMENT, 1) = displacement_start_time_step; | |
| p_node->GetSolutionStepValue(DISPLACEMENT, 0) = displacement_end_time_step; |
| KRATOS_TEST_CASE_IN_SUITE(ComputeIncrementalDisplacementField, KratosGeoMechanicsFastSuite) | ||
| { | ||
| Model model; | ||
| auto& model_part = CreateDummyModelPart(model); |
There was a problem hiding this comment.
Strictly speaking, we should prefix this name with r_ to comply with the Kratos Style Guide. Having said that, I can imagine that this minor inconsistency appears in other tests in the same file as well. So we could either correct those as well, or do that in a separate PR. I'll leave that up to you.
There was a problem hiding this comment.
Done for this .cpp file.
rfaasse
approved these changes
Apr 25, 2024
loumalouomega
pushed a commit
that referenced
this pull request
Apr 29, 2024
…nd integration test. (#12288) * Incremental displacement variable, output and integration test. * Output enabled fhrough the C++ route too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
For clear display of failure mechanisms we would like to inspect the extra deformations computed during one step, additional to the displacements since the start of a stage.
🆕 Changelog