[GeoMechanicsApplication] Add 1D functionality to existing 2D/3D Pw element #12292

mnabideltares · 2024-04-18T18:09:47Z

📝 Description
As user we would like to implement well-element for geothermal high capacity heat storage. For this, we need 1D pressure and thermal elements. However, 1D pressure element does not exist in the current implementation.

Here, we would like to add a generic 1D pressure line element (to be used for well-element in the later implementation).

🆕 Changelog

Added pressure line element class, inherited directly from Element class.
Registered the elements
Added test cases

markelov208

Hi Mohamed, a great work and many tests added. I put some comments. It looks that we have already implemented similar things.

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.cpp

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

applications/GeoMechanicsApplication/tests/test_pressure_line_element.py

rfaasse

This is nicely added as derived from the Element class and does not add to the hierarchy tree we are trying to clean up!

There are still some duplications in here that I think we should be able to clean up. We can have a discussion what would be the best way to do this (we could for example create a small PR to extract some functionality to a utility function, such that we can re-use it here and in the other places where we have defined some of these functions.

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.cpp

applications/GeoMechanicsApplication/custom_utilities/element_utilities.hpp

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

applications/GeoMechanicsApplication/tests/test_pressure_line_element.py

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

markelov208

Hi Mohamed, many thanks for the conversation and fixing the code. Let's move on ;)

WPK4FEM

Dear Mohammed,
Not sure if all my remarks on the code should be taken up. However, I find it quite important to have follow up on some of the remarks on tests. 3D is unintentionally using 2D elements.
Regards, Wijtze Pieter

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

WPK4FEM · 2024-04-25T13:38:38Z

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

+                                            const BoundedMatrix<double, TNumNodes, TNumNodes>& rCompressibilityMatrix,
+                                            double DtPressureCoefficient)
+    {
+        rLeftHandSideMatrix = rPermeabilityMatrix + DtPressureCoefficient * rCompressibilityMatrix;


Very readable, like a formula.
The name of the function however says AddContributionsTo. That is not what this formula states.

WPK4FEM · 2024-04-25T13:40:36Z

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

+            array_1d<double, TNumNodes>{-prod(rCompressibilityMatrix, GetNodalValuesOf(DT_WATER_PRESSURE))};
+        const auto permeability_vector =
+            array_1d<double, TNumNodes>{-prod(rPermeabilityMatrix, GetNodalValuesOf(WATER_PRESSURE))};
+        rRightHandSideVector = compressibility_vector + permeability_vector + rFluidBodyVector;


Same here: very readable like a formula.
The function name AddContributionsTo sounds like += i.s.o. the =

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

...cation/tests/test_pressure_line_element/test_oblique_line_element3D2N/ProjectParameters.json

...ation/tests/test_pressure_line_element/test_vertical_line_element3D2N/ProjectParameters.json

...est_pressure_line_element/test_vertical_line_element3D2N/test_vertical_line_element3D2N.mdpa

...ation/tests/test_pressure_line_element/test_vertical_line_element3D3N/ProjectParameters.json

...est_pressure_line_element/test_vertical_line_element3D3N/test_vertical_line_element3D3N.mdpa

rfaasse

Thanks a lot for all your efforts in processing review comments and adding the documentation, I have one question left about the tangential vector, but next to the open comments from Wijtze Pieter, I have nothing to add!

applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h

applications/GeoMechanicsApplication/tests/test_pressure_line_element/README.md

applications/GeoMechanicsApplication/tests/test_pressure_line_element.py

rfaasse

Looks good to me!

WPK4FEM

Lets go and in a separate commit make naming for LHS and RHS computation consistent in both Pw and T elements.

WPK4FEM · 2024-04-26T14:49:23Z

...ns/GeoMechanicsApplication/tests/test_pressure_line_element/Common/MaterialParameters2D.json

+        "BIOT_COEFFICIENT"                 : 1.000000e+00,
+        "RETENTION_LAW"                    : "SaturatedLaw",
+        "SATURATED_SATURATION"             : 1.000000e+00,
+        "RESIDUAL_SATURATION"              : 0.000000e+00


Is RESIDUAL_SATURATION needed for the SaturatedLaw? The 3D materials parameters files shows that it is possible without.

mnabideltares added 6 commits April 16, 2024 15:06

Added pressure line element

29a66c6

Added fluid_body_vector and projected the gravity along the element

d20b2a0

Cleaned unused variable(s)

ff9aac0

Merge branch 'master' into geo/12267-add-1d-pressure-element

11cef1c

Added 8 test cases

7897c9e

cleanup

c098b94

mnabideltares linked an issue Apr 18, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Add 1D functionality to existing 2D/3D Pw element #12267

Closed

modifications based on sonar code smells

8df634f

mnabideltares requested review from rfaasse, WPK4FEM, avdg81 and markelov208 April 22, 2024 07:55

clean up

295c41f

markelov208 reviewed Apr 22, 2024

View reviewed changes

rfaasse reviewed Apr 22, 2024

View reviewed changes

mnabideltares added 9 commits April 23, 2024 01:59

Added 3D pressure line element + test cases

c6008ed

modifications based on review

c1eb8bc

modifications based on review 2

c106ce8

modifications based on review 3

3ac1dbe

README.md is added for the test cases

ec4b4d9

fix README

58c8e95

another fix README

22d8610

fix

dcc107b

a small fix in README.md

c46fb69

mnabideltares requested review from markelov208 and rfaasse April 25, 2024 12:05

Fixed variable names to camel case for input parameters

491de4f

markelov208 previously approved these changes Apr 25, 2024

View reviewed changes

WPK4FEM requested changes Apr 25, 2024

View reviewed changes

Modifications based on review comments

1711f5d

mnabideltares dismissed markelov208’s stale review via 1711f5d April 25, 2024 21:37

rfaasse reviewed Apr 26, 2024

View reviewed changes

Modifications based on review comments - continue

3766518

rfaasse approved these changes Apr 26, 2024

View reviewed changes

mnabideltares requested review from markelov208, rfaasse and WPK4FEM April 26, 2024 11:15

WPK4FEM approved these changes Apr 29, 2024

View reviewed changes

mnabideltares merged commit 0680276 into master Apr 29, 2024
11 checks passed

mnabideltares deleted the geo/12267-add-1d-pressure-element branch April 29, 2024 09:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Add 1D functionality to existing 2D/3D Pw element #12292

[GeoMechanicsApplication] Add 1D functionality to existing 2D/3D Pw element #12292

mnabideltares commented Apr 18, 2024

markelov208 left a comment

rfaasse left a comment

markelov208 left a comment

WPK4FEM left a comment

WPK4FEM Apr 25, 2024

WPK4FEM Apr 25, 2024

rfaasse left a comment

rfaasse left a comment

WPK4FEM left a comment

WPK4FEM Apr 26, 2024

[GeoMechanicsApplication] Add 1D functionality to existing 2D/3D Pw element #12292

[GeoMechanicsApplication] Add 1D functionality to existing 2D/3D Pw element #12292

Conversation

mnabideltares commented Apr 18, 2024

markelov208 left a comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

WPK4FEM Apr 25, 2024

Choose a reason for hiding this comment

WPK4FEM Apr 25, 2024

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

WPK4FEM Apr 26, 2024

Choose a reason for hiding this comment