-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Extract a static utility function for the calculation of the Mass Matrix (M) #12299
Merged
Merged
Changes from 65 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
50f3582
implemented CalculateMassMatrix for small_strain_U_Pw_diff_order_element
ea4cc17
removed CalculateMassMatrix
0dd0c5a
replaced rGeom with this->GetGeometry()
fc82a72
added description of CalculateMassMatrix
83f27a1
added Np, changed from Camel to snake_case
122e145
removed CalculateMassMatrix
d1ea2e1
removed commented lines
27b872a
removed Np vector
561390d
changed in accordance SOnarCloud:
2802e2b
extracted CalculateMassMatrix for U_Pw_small_strain_element
db42ede
replaced local CalculateSoilDensity functions with the static function
f632a3b
fixed extracted CalculateMassMatrix for U_Pw_small_strain_element
1fec4e6
fixed return of MassMatrix
4e56457
removed unique_ptr from function parameters
684103f
Revert "removed CalculateMassMatrix"
bf235ca
extracted CalculateDegreeOfSaturation and CalculateIntegrationCoeffic…
d8abb63
changed MassMatrix to mass_matrix
1e5a696
added CalculateNuMatrix for Matrxi1&Matrix2 and clang-formatting
7d7ac07
changed in accordance with the review comments
cfd8da6
added test for CalculateSoilDensity function
a14951c
removed index=i-Dim
3d5bd1f
replaced pointer with reference
6417b44
replaced pointer with reference -cont
f59640e
removed redundant NumberPNodes
4d877be
changed RetentionParameters to snake_case
99beebb
reduced info passed into CalculateDegreeOfSaturation
516b822
changed rpPressureGeometry to rPressureGeometry
3172490
added equation_of_motion_utilities and extracted CalculateSoilDensity…
065e3ff
Merge branch 'master' into geo/12279-extract-function-mass-matrix
e418105
added test for CalculateMatrix etc functions for U_Pw_small_strain_el…
af39cf6
added a unit test for UPwDiffOrder element
5162f11
removed unnecessary includes
6738424
fixed sonarcloud smells
e865caa
added a description of Equation of Motion utilities
02cd28d
changed CalculateSoilDensityVector to CalculateSoilDensities
419de5f
updated descriptions of transport_equation_utilities.hpp and equation…
b413a81
removed a copy of CalculateIntegrationCoefficientInitialConfiguration
be659ba
removed redundant input rIntegrationPoints and updated unit tests
5e159f3
activated 1D-consolidation test
6c60525
reduced test_mass_matrix for debugging
961954c
test only for SolidDensities for DiffOrder
66551cd
commented CalculateSoilDensities in the test
3921b67
corrected size of pressure_vector
d29c4b5
moved geometry creation to model_setup_utilities function
e53ba8c
deactivated 1d_consolidation test
419bbfe
used pragma once
35d8b43
removed parentheses
1e64d18
used arithmetic operations instead the final numbers
56b5828
removed commented includes
de3af9a
Merge branch 'master' into geo/12279-extract-function-mass-matrix
500d098
renamed some local variables and removed unused includes
63cc3dd
removed unused includes in equations_of_motion_utilities.hpp
f22c8a4
added s in CalculateIntegrationCoefficientsInitialConfiguration
3c04353
fixed porosity and soil density description
5879c6b
restored CalculateMassMatrix for DiffOrder element
2e1ed28
used available elements' CalculateIntegrationCoefficients and removed…
fc15f3e
split equation_of_motion_utilities.hpp into h and cpp files
8ed6b14
removed unused includes in test_mass_matrix
7f10d5f
removed unused dN_De in equation_of_motion_utilities
99b0fba
moved getting of pressure solution vector from transport_equation_uti…
19559c6
removed extra qualification for GetPressureSolutionVector
383176a
removed private functions in transport_equation_utilities.hpp
c5c44ba
added this-> for CalculateIntegrationCoefficients call
1572298
extracted CalculateDegreesSaturation from CalculateSoilDensities
9012aeb
changed setting of properties to remove a code smell
cf9f0d9
changed include statements following the review comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very similar (but nicer written) to the GetNodalVariableVector or Matrix functions in element_utilities.hpp
Maybe this functionality belongs there.