[Core] Fix Average Element size calculator for 2D9N #12301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
added
Bugfix
Kratos Core
FastPR
|
Thanks for the fix @sunethwarna. After passing the checks I will approve it. |
philbucher
reviewed
Apr 22, 2024
| @@ -867,7 +867,7 @@ double ElementSizeCalculator<2,4>::AverageElementSizeDerivative( | |||
| template<> | |||
| double ElementSizeCalculator<2,9>::AverageElementSize(const Geometry<Node >& rGeometry) | |||
| { | |||
| return rGeometry.Length(); | |||
| return rGeometry.Length() * 2.0; | |||
There was a problem hiding this comment.
hm so thats a hack for the hack?
Can you add a comment? :D
philbucher
reviewed
Apr 22, 2024
|
I am planning to add tests for all the geometries :) |
|
Will you add the tests in this PR or in future? |
|
I will do it with the same PR, but not today. Would you be able to wait until this Friday? |
|
Sure, we can wait. |
|
Ok I have added the tests. @philbucher @jgonzalezusua :) |
philbucher
approved these changes
Apr 29, 2024
jgonzalezusua
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
As mentioned in the title, this corrects the average length calculation of the
Quad2D9Nto be consistent with the linear computation.closes #12300
🆕 Changelog
Quad2D9N