-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mapping] Implementing == and != operators #12317
Conversation
@loumalouomega I am not sure if we can approve this right away, the idea was to discuss with @philbucher if the equality operators need to take into consideration the distance or not. |
I am aware, will check in on the weekend. This is sth I need to think about and remember what I did |
Any news? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I remember!
The id does not matter for the comparison, I only care about the distance
I.e. the inheritance from IndexedObject
does not matter here
wait, I think there is more to it after all 🤔 |
@philbucher Done with the changes. |
📝 Description
==
and!=
operators are needed for the GTestcurrently the tests assume that distance is not checked, but it should?
🆕 Changelog
==
operator!=
operator