Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Fixed the bug related to shape-function-gradients for thermal line el… #12347

Merged
merged 2 commits into from
May 8, 2024

Conversation

mnabideltares
Copy link
Contributor

📝 Description
There is a bug detected in the calculation of shape function gradients for line thermal element. The shape fuction gradient is calculated based on the local coordinates. Later it has to be multiplied by the inverse of the Jacobian in order to be projected to the global coordinates. However, a such multiplication is missing.

🆕 Changelog

Added a statement to divide the shape-function-gradients to the determinant of Jacobian. In 1D, this is equvalent to multiplication with inverse Jacobian

@mnabideltares mnabideltares requested review from rfaasse and WPK4FEM May 6, 2024 10:05
@mnabideltares mnabideltares self-assigned this May 6, 2024
@mnabideltares mnabideltares changed the title Fixed the bug related to shape-function-gradients for thermal line el… [GeoMechanicsApplication] Fixed the bug related to shape-function-gradients for thermal line el… May 6, 2024
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out of the other PR, a very easy to review PR like this! I was just wondering if we can illustrate this bug already without point source flux, but I don't have any other comments, so if that's unnecessarily hard to do without the other PR, this is good to go from my point of view

Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Mohammed,
After spending some effort on rewriting the if else structure for the computation of the dN_dX container, the result of that is not better than what you have shown here.
After consulting with Anne and Richard we would appreciate if you ad a comment before line 74 e.g.
// ShapeFunctionsIntegrationsPointsGradients does not allow for the line element in 2D/3D configuration and will produce errors. To circumvent this, the dN_dX_container is separately computed with correct dimensions for the line element.
Regards, Wijtze Pieter

@WPK4FEM WPK4FEM added the GeoMechanics Issues related to the GeoMechanicsApplication label May 7, 2024
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@mnabideltares mnabideltares merged commit 462a200 into master May 8, 2024
11 checks passed
@mnabideltares mnabideltares deleted the geo/12344-fix-bug-thermal-line-element branch May 8, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GeoMechanics Issues related to the GeoMechanicsApplication
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Fix bug in calculation of shape-function-gradients in thermal element.
3 participants