[GeoMechanicsApplication] Add cross-sectional area to the thermal line element #12349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WPK4FEM
approved these changes
May 6, 2024
There was a problem hiding this comment.
Hi Mohammed,
Thank you, this removes a good amount of duplication by reuse of the MaterialProperties.
In this way all existing tests keep giving the same answer. It would be good if a future test that combines line and volume (or plane) elements contains a CROSS_AREA that is not 1.0
rfaasse
approved these changes
May 6, 2024
applications/GeoMechanicsApplication/custom_elements/transient_thermal_element.h
Show resolved
Hide resolved
mnabideltares
deleted the
geo/12346-add-sectional-area-thermal-line-element
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The line element has to be extended to include the sectional area. All terms in the heat equation has to be multiplied with the sectional area. In principle, it does not make change in the results for an isolated 1D line element. The effect will appear when the 1D line element gets combined with 2D element, for example, when a well or pipe inside the soil gets simulated. The matrices of this 1D element will be superposined with the 2D elements in the main matrix.
🆕 Changelog