[Core] Adding a method to fetch the non-converged solutions from the NewtonRaphson strategy #12375
Conversation
Sub-optimal as it requires variables to be passed. A better solution should simply gather variables from the dofset
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
…son_strategy.h Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
…son_strategy.h Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
…son_strategy.h Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
…son_strategy.h Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
kratos/solving_strategies/strategies/residualbased_newton_raphson_strategy.h
Outdated
Show resolved
Hide resolved
|
Shouldn't we add this to the base implicit strategy? |
| void SetUpNonconvergedSolutionsGathering(){ | ||
| mStoreNonconvergedSolutionsFlag = true; |
There was a problem hiding this comment.
It is a good practice to make the member var match the name of the inquiry and set methods.
There was a problem hiding this comment.
Method's name now matches the flag's
| * @brief Sets up the gathering of non-converged solutions | ||
| * @details This method enables the storage of non-converged solutions at each iteration by setting the appropriate flag. | ||
| */ | ||
| void SetUpNonconvergedSolutionsGathering(){ |
There was a problem hiding this comment.
You should pass the bool to be set in here.
| * @return A vector containing the current solution values for the given DOF set | ||
| * @details This method retrieves the current solution values for the provided DOF set. Each value is accessed using the equation ID associated with each DOF. | ||
| */ | ||
| Vector GetCurrentSolution(DofsArrayType& rDofSet){ |
There was a problem hiding this comment.
I think we should pass a reference in here. Otherwise we are creating a copy at return time.
There was a problem hiding this comment.
Reference is now passed to avoid copies
| */ | ||
| Vector GetCurrentSolution(DofsArrayType& rDofSet){ | ||
| Vector this_solution(rDofSet.size()); | ||
| for (auto& r_dof : rDofSet) { |
There was a problem hiding this comment.
| for (auto& r_dof : rDofSet) { | |
| for (auto& r_dof : rDofSet) { |
Can't this be done in parallel?
There was a problem hiding this comment.
using block for each now
The base class does not implement iterations. By adding this here, we ensure that non-converged solutions are collected for both the Newton-Raphson and Line Search strategies. Many applications do not re-implement this method in derived strategies, so we thought implementing it here is the most suitable approach. |
|
Eeeh honestly this seems to me like a hack. I like the idea, but I'd rather add infrastructure to allow hooking output processes into the strategy base class. Is something like that possible? |
Well this would be a major change. As we discussed we should definitely do a redesign of the strategies etc and we could think about your proposal as a part of that, nevertheless this is a small, completely backward compatible, change. My proposal would be to accept it "as is" and discuss your proposal in the context of a "strategy v2", for example during your stay in BCN in 10 days from now |
|
Fine by me. |
|
then i am approving |
📝 Description
This PR adds the possibility to store all nonconvereged solutions during the iterative procedure. After either convergence has been achieved or the maximum number of iterations has been reached, one can fetch a Kratos Matrix containing the nonconvereged solutions. The relevant method also returns the dof set in case the matrix should be treated.
If the Setup method is not called, no overhead is introduced.
🆕 Changelog