Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optapp/fix rgp #12413

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Optapp/fix rgp #12413

merged 7 commits into from
Jun 18, 2024

Conversation

Igarizza
Copy link
Member

@Igarizza Igarizza commented May 31, 2024 •
edited
Loading

📝 Description
The PR add few small fixes for RGP and adds unittest to check all internal components of the RGP algorithm.
Fixes:

  • adding collapse to Update
  • output zero gradients of the non-active constaints
  • fix the computation of norm of the constraint
  • fix GetActiveConstraintList
  • fix Buffer Logic
  • Adding unittest

sunethwarna
sunethwarna approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Igarizza

@Igarizza Igarizza merged commit 8c9bf25 into master Jun 18, 2024
11 checks passed
@Igarizza Igarizza deleted the optapp/fixRGP branch June 18, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunethwarna sunethwarna sunethwarna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Igarizza @sunethwarna