Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Precalculate fluid pressures and Bishop coefficients #12434

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented Jun 6, 2024

📝 Description
Added two missing precalculations of the fluid pressures and the Bishop coefficients. This addresses two review comments that were submitted for PR 12423, but that were actually unrelated to the aim of that PR.

@avdg81 avdg81 added FastPR This Pr is simple and / or has been already tested and the revision should be fast GeoMechanics Issues related to the GeoMechanicsApplication labels Jun 6, 2024
@avdg81 avdg81 requested a review from rfaasse June 6, 2024 15:14
@avdg81 avdg81 self-assigned this Jun 6, 2024
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, looks good to go!

@avdg81 avdg81 merged commit 877cd7a into master Jun 10, 2024
11 checks passed
@avdg81 avdg81 deleted the geo/process-pending-review-comments branch June 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants