Geo/consolidation test #12435
Merged
Geo/consolidation test #12435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WPK4FEM
added
Behaviour Change
avdg81
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
A clear and small PR that restores the old behavior such that the 1D consolidation works again.
I have verified that this PR reverts the code change made here. That commit also updated the comment from "stress and strain vectors must be initialized:" to "stress vector must be initialized:". Not sure whether you would also like to restore that one...?
And thanks for correcting the mesh_move_flag option: it didn't make any sense here to have it on.
From my point of view, this PR is good to go.
WPK4FEM
force-pushed
the
geo/consolidation_test
branch
from
32cfb6c to
99ab1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Activation of the GeoMechanicsApplication 1D consolidation test.
🆕 Changelog
This implies: