Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptApp] Simp Control Allow not removing materials #12460

Merged

Conversation

sunethwarna
Copy link
Member

📝 Description
As in the title

🆕 Changelog

  • Changed the SimpControl to disallow removing materials
  • Changed the tests accordingly.

@sunethwarna sunethwarna added Applications Python FastPR This Pr is simple and / or has been already tested and the revision should be fast Optimization related to OptApp labels Jun 14, 2024
@sunethwarna sunethwarna self-assigned this Jun 14, 2024
@@ -134,6 +138,10 @@ def test_AdaptiveBeta(self):
parameters = Kratos.Parameters("""{
"controlled_model_part_names": ["shell"],
"list_of_materials": [
{
"density": 0.0,
"young_modulus": 0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test please without zeros

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

altry :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@sunethwarna sunethwarna requested a review from Igarizza June 14, 2024 07:59
Igarizza
Igarizza previously approved these changes Jun 14, 2024
Copy link
Member

@Igarizza Igarizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@sunethwarna sunethwarna dismissed Igarizza’s stale review June 14, 2024 08:35

The merge-base changed after approval.

@sunethwarna sunethwarna requested a review from Igarizza June 14, 2024 09:47
@sunethwarna
Copy link
Member Author

ping @Igarizza

Igarizza
Igarizza previously approved these changes Jun 18, 2024
Copy link
Member

@Igarizza Igarizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunethwarna sunethwarna dismissed Igarizza’s stale review June 18, 2024 11:08

The merge-base changed after approval.

@sunethwarna sunethwarna enabled auto-merge June 18, 2024 11:26
Igarizza
Igarizza previously approved these changes Jun 27, 2024
@sunethwarna sunethwarna dismissed Igarizza’s stale review June 27, 2024 08:53

The merge-base changed after approval.

@sunethwarna sunethwarna requested a review from Igarizza June 27, 2024 08:55
Igarizza
Igarizza previously approved these changes Jun 27, 2024
@sunethwarna sunethwarna removed the request for review from RezaNajian June 27, 2024 08:57
@sunethwarna sunethwarna disabled auto-merge June 27, 2024 08:57
@sunethwarna sunethwarna dismissed Igarizza’s stale review June 27, 2024 09:04

The merge-base changed after approval.

@sunethwarna sunethwarna requested a review from Igarizza June 27, 2024 09:05
Igarizza
Igarizza previously approved these changes Jun 27, 2024
@sunethwarna sunethwarna enabled auto-merge June 27, 2024 09:10
@sunethwarna sunethwarna merged commit f42c10c into master Jun 27, 2024
11 checks passed
@sunethwarna sunethwarna deleted the optapp/controls/shape_thickness/allow_material_non_removal branch June 27, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications FastPR This Pr is simple and / or has been already tested and the revision should be fast Optimization related to OptApp Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants