[GeoMechanicsApplication] Remove extra redundant calculations of displacement for thermal and Pw elements #12462
Conversation
…Pw elements Adjusted the integration tests accordingly
| "scheme_type": "Backward_Euler", | ||
| "reset_displacements": true, | ||
| "newmark_beta": 0.25, |
There was a problem hiding this comment.
Indeed it can be deleted, the defaults in geomechanics_U_Pw_solver.py and in geomechanics_solver.py are both false.
( In future we probably should make sure there is only 1 place where this setting has its default. )
| @@ -61,7 +60,6 @@ | |||
| "min_alpha": 0.1, | |||
| "max_alpha": 2.0, | |||
| "line_search_tolerance": 0.5, | |||
There was a problem hiding this comment.
Same here, deletion is correct, , the defaults in geomechanics_U_Pw_solver.py and in geomechanics_solver.py are both false.
( In future we probably should make sure there is only 1 place where this setting has its default. )
| @@ -32,7 +32,6 @@ | |||
| "block_builder" : true, | |||
| "solution_type" : "Transient_Groundwater_Flow", | |||
| "scheme_type" : "Backward_Euler", | |||
There was a problem hiding this comment.
Already false, but I agree with removing items that have no meaning for the analysis.
| @@ -52,14 +51,12 @@ | |||
| "desired_iterations" : 2, | |||
| "max_radius_factor" : 10.0, | |||
| "min_radius_factor" : 0.1, | |||
| "calculate_reactions" : true, | |||
There was a problem hiding this comment.
Is this intentially deleted? In thermal analysis, I expect the reaction computation to compute nodal reaction flows at the Dirichlet boundary conditions and zero nodal flow and other nodes that are without Dirichlet and Neumann boundary conditions.
Furhter, I think remove the "calculate_reactions" : true, has no effect. The defaults in geomechanics_U_Pw_solver.py and geomechanics_solver.py, geomechanics_Pw_solver.py and geomechanics_T_solver.py are all true.
There was a problem hiding this comment.
I agree with deleting this file, the ProjectParameters file points to another place for the material.
📝 Description
In the solver, functions for displacement are called which are not necessary for thermal and Pw elements. These functions cause a lot of redundant calculations and significantly slow down the process.
Moreover, in the most of test cases related to thermal and Pw elements, "reset_displacement=true" is used. It came probably from GID generated files. This is redundant for such elements and need to be removed.
🆕 Changelog