Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix Extrapolation in Table::GetDerivative #12471

Closed
wants to merge 3 commits into from
Closed

[Core] Fix Extrapolation in Table::GetDerivative #12471

wants to merge 3 commits into from

Conversation

matekelemen
Copy link
Contributor

Table::GetValue continues on the last (or first) slope if the input value is out of bounds, but Table::GetDerivative returns 0 in these regions.

This PR makes the behaviour of Table::GetDerivative consistent with Table::GetValue.

@matekelemen matekelemen requested a review from sunethwarna June 20, 2024 08:18
@matekelemen matekelemen requested a review from a team as a code owner June 20, 2024 08:18
loumalouomega
loumalouomega previously approved these changes Jun 20, 2024
View reviewed changes
@philbucher
Copy link
Member

can you add a test please?

@sunethwarna sunethwarna mentioned this pull request Jun 27, 2024
Merged
@avdg81
Copy link
Contributor

avdg81 commented Jun 27, 2024

It has been fixed by #12477 (thanks to @sunethwarna for reviewing and approving).

@matekelemen matekelemen deleted the core/table-derivative branch January 31, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loumalouomega loumalouomega loumalouomega approved these changes

@sunethwarna sunethwarna Awaiting requested review from sunethwarna

Assignees
No one assigned
Labels
Bugfix C++ Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matekelemen @philbucher @avdg81 @loumalouomega