[GeoMechanicsApplication] added process to calculate incremental displacement #12474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronnoordam
changed the title
aronnoordam
added
C++
Performance
GeoMechanics
| KRATOS_TRY | ||
|
|
||
| block_for_each(mrModelPart.Nodes(), [&](Node& rNode) { | ||
| rNode.FastGetSolutionStepValue(INCREMENTAL_DISPLACEMENT) = rNode.FastGetSolutionStepValue(DISPLACEMENT, 0) - rNode.FastGetSolutionStepValue(DISPLACEMENT, 1); |
There was a problem hiding this comment.
Suggested change
| rNode.FastGetSolutionStepValue(INCREMENTAL_DISPLACEMENT) = rNode.FastGetSolutionStepValue(DISPLACEMENT, 0) - rNode.FastGetSolutionStepValue(DISPLACEMENT, 1); | |
| noalias(rNode.FastGetSolutionStepValue(INCREMENTAL_DISPLACEMENT)) = rNode.FastGetSolutionStepValue(DISPLACEMENT, 0) - rNode.FastGetSolutionStepValue(DISPLACEMENT, 1); |
There was a problem hiding this comment.
this will also save some time
|
Check also the |
will do, thanks |
avdg81
reviewed
Jul 8, 2024
...ions/GeoMechanicsApplication/custom_processes/calculate_incremental_displacement_process.cpp
Show resolved
Hide resolved
...ations/GeoMechanicsApplication/custom_processes/calculate_incremental_displacement_process.h
Outdated
Show resolved
Hide resolved
...ations/GeoMechanicsApplication/custom_processes/calculate_incremental_displacement_process.h
Show resolved
Hide resolved
...ions/GeoMechanicsApplication/custom_processes/calculate_incremental_displacement_process.cpp
Outdated
Show resolved
Hide resolved
...ions/GeoMechanicsApplication/custom_processes/calculate_incremental_displacement_process.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_python/add_custom_processes_to_python.cpp
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_python/add_custom_processes_to_python.cpp
Outdated
Show resolved
Hide resolved
…lculate_incr_disp_process # Conflicts: # applications/GeoMechanicsApplication/custom_python/add_custom_processes_to_python.cpp
avdg81
reviewed
Jul 10, 2024
There was a problem hiding this comment.
I only have a few very minor comments regarding the unit test. Apart from that, I believe this PR is ready to go. Thanks for the work done @aronnoordam !
.../GeoMechanicsApplication/tests/cpp_tests/test_calculate_incremental_displacement_process.cpp
Outdated
Show resolved
Hide resolved
.../GeoMechanicsApplication/tests/cpp_tests/test_calculate_incremental_displacement_process.cpp
Outdated
Show resolved
Hide resolved
.../GeoMechanicsApplication/tests/cpp_tests/test_calculate_incremental_displacement_process.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Anne van de Graaf <[email protected]>
avdg81
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved calculation of incremental displacement from python to cpp as this was a bottleneck