Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StructApp] Bushing element #12487

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Conversation

sunethwarna
Copy link
Member

@sunethwarna sunethwarna commented Jun 27, 2024

📝 Description
This PR implements BushingElement which couples displacement and rotational dofs and can have either constant stiffness or tabulated force/displacement and moment/rotation data in each direction if required.

🆕 Changelog

  • Added BushingElement
  • Added tests

@philbucher
Copy link
Member

Nice, I would like to take a look
If I havent replied by Monday evening then please go ahead without my review ;)

@sunethwarna sunethwarna requested a review from philbucher June 27, 2024 10:07
philbucher
philbucher previously approved these changes Jul 1, 2024
Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment on lines +116 to +118
BushingElement::~BushingElement()
{
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

///@name Private member variables
///@{

array_1d<Stiffness::UniquePointer, 6> mStiffnessGetters;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not std array?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no specific reason... I can change it :)

///@name Kratos Classes
///@{

class KRATOS_API(STRUCTURAL_MECHANICS_APPLICATION) BushingElement: public Element
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add some docs? It is not very clear what this does/how it should be used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will :)

@sunethwarna
Copy link
Member Author

The documentation is being added in the #12771. Hence merging this :)

@sunethwarna sunethwarna merged commit 64a1cbc into master Oct 22, 2024
11 checks passed
@sunethwarna sunethwarna deleted the structapp/elements/bushing_element branch October 22, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants