[Core] Introduce PointerComparor and remove DofPointerComparor #12509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
requested review from
loumalouomega,
a team,
pooyan-dadvand,
RiccardoRossi,
roigcarlo and
rubenzorrilla
and removed request for
a team
loumalouomega
approved these changes
Jul 5, 2024
|
The failure in DamApplication is unrelated to this. It is failing because, one of the variables which is being used is not included in the solution step variables list. I am not sure who to tag. Any ideas @roigcarlo ? |
|
On it. |
|
The implementation is ok for me. Waiting for the unit tests to approve |
…e_dof_pointer_comparor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR removes the redundant
DofPointerComparorbecause, the operators forDof<double>is nicely done in thedof.h. This PR introduces more generalPointerComparor, which uses theTDataType::operator==to compare. So, if someone was using (atleast I did not find any use cases in the master) theDofPointerComparor, they can easily change and usePointerComparor. The test was changed accordignly.🆕 Changelog
DofPointerComparorPointerComparor