[CoSimulationApplication] Adding VTK debugging option for Kratos Mapping

[loumalouomega]

📝 Description

Adding new mapping class with VTK debuggin, derived from Kratos Mapping.

For example can be sued as follows:

"data_transfer_operators" : {
      "mapper" : {
          "type" : "kratos_mapping_with_debug",
          "mapper_settings" : {
              "mapper_type" : "nearest_neighbor"
          },
          "debug_settings" : {
              "auxiliary_debug_counter" : true
          }
      }
  }

It will generate VTK folder for the pre and post mapping.

🆕 Changelog

• Adding VTK debugging option for Kratos Mapping
• Adding auxiliary counter for wrappers without TIME or STEP defined

[loumalouomega]

For some reason FSI tests are failing in the FSIApp but this does not affect that application.

[philbucher]

Will do a review on the weekend

[philbucher]

I think this is a good addition, but the implementation should be moved to a CouplingOperation instead, this is the intended place for such things

Check for example the CouplingOutput which has a similar purpose

=> then the user can add it to the coupling_operations and call it before_data_transfer_operations or after_data_transfer_operations

[philbucher]

I would use the vtk_output directly, then you only need to call PrintOutput, and not have all the overhead of the process

[loumalouomega]

I understand your point, but the problem with that impliementation is that I will need to manually add the settings for the IO instead of automatically deduce the variables and settings from the mapping like I do in the current proposal.

[loumalouomega]

Ping @philbucher

[loumalouomega]

We should discuss this @philbucher. Currently I need to transfer the files to the interested people for debug and it is a bit inconvinient

[philbucher]

oh sorry I completely forgot, will take a look over the weekend
Pls let me know when you are done with your changes

[loumalouomega]

A priori it is done, I am just adding some minor fixes from internal feedback

[philbucher]

I had a look and TBH its very complicated and not very nicely done

How about you derive a class from it, e.g. kratos_mapping_with_debug_output to not mess up the baseclass?

[philbucher]

please move the additions in this file, they should not be in the baseclass

[loumalouomega]

I had a look and TBH its very complicated and not very nicely done

Theare are better ways to express that :P

How about you derive a class from it, e.g. kratos_mapping_with_debug_output to not mess up the baseclass?

I could do that

[philbucher]

Theare are better ways to express that :P

I tried my best, sry 😓

[loumalouomega]

Theare are better ways to express that :P

I tried my best, sry 😓

Should be Okay now

[loumalouomega]

Suggestions applied @philbucher

[loumalouomega]

Are you Okay now @philbucher ¿?

[philbucher]

👍

[philbucher]

ah my archnemesis, typing in python ...

/rant over

[loumalouomega]

It was your suggestion...

[philbucher]

I know, its the direction the language goes, smarter ppl than me design this

still, I can complain about it :D

[loumalouomega]

@roigcarlo do you think it is possible to cherry-pick this into a minor release?

[loumalouomega]

Finally

[philbucher]

Finally

still does not take as long as my phd ...

[roigcarlo]

I Will include it in 10.0