[GeoMechanicsApplication] Cleanup of the head extrapolation unit tests #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfaasse
added
the
Refactor
avdg81
reviewed
Jul 19, 2024
| @@ -10,112 +10,81 @@ | |||
| // Main authors: Jonathan Nuttall | |||
| // | |||
|
|
|||
| #include <string> | |||
| #include <iostream> | |||
There was a problem hiding this comment.
I'm not sure why we would need to include iostream here. I do see that we use std::filesystem. I've tried to replace iostream by the more appropriate filesystem and that seems to work.
Suggested change
| #include <iostream> | |
| #include <filesystem> |
What are your thoughts about this?
| &flow_stubs::emptyCancel); | ||
|
|
||
| const int status = execute.ExecuteFlowAnalysis(workingDirectory, projectFile, critical_head_info, "", call_back_functions); | ||
| int RunTestCase(int test_case_number) |
There was a problem hiding this comment.
To follow the Kratos Style Guide, please rename the parameter as follows:
Suggested change
| int RunTestCase(int test_case_number) | |
| int RunTestCase(int TestCaseNumber) |
This suggestion also applies to the parameter of function CompareResults.
markelov208
previously approved these changes
Jul 19, 2024
|
|
||
| KRATOS_EXPECT_TRUE(TestUtilities::CompareFiles(original, result)) | ||
| return execute.ExecuteFlowAnalysis(workingDirectory.generic_string(), projectFile, |
There was a problem hiding this comment.
Tests work when return KratosExecute().ExecuteFlowAnalysis(...). What is your opinion on having line 35?
There was a problem hiding this comment.
Nice suggestion, indeed makes it shorter and clearer in my opinion
markelov208
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Minor cleanup effort for the unit tests in
test_head_extrapolation_workflow.cpp. I did the clean-up before, but didn't want to introduce more merge conflicts for the ci/gtests branch. Now that is done, this can be merged