Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContactStructuralMechanicsApp] Solving minor restart bug with contact #12534

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

AlejandroCornejo
Copy link
Member

@AlejandroCornejo AlejandroCornejo commented Jul 12, 2024

name: ✨ Hotfix
about: Now restart with contact simulations WORKS

This was investigated by @lagoncalvesjr , I'm just merging the findings.

Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@loumalouomega
Copy link
Member

name: ✨ Hotfix about: Now restart with contact simulations WORKS

This was investigated by @lagoncalvesjr , I'm just merging the findings.

I see it was a very stupid error, thanks @AlejandroCornejo

@AlejandroCornejo
Copy link
Member Author

name: ✨ Hotfix about: Now restart with contact simulations WORKS
This was investigated by @lagoncalvesjr , I'm just merging the findings.

I see it was a very stupid error, thanks @AlejandroCornejo

yes!! simple to solve but difficult to find, thanks to @roigcarlo and @lagoncalvesjr

@AlejandroCornejo
Copy link
Member Author

please @lagoncalvesjr check if these changes are correct

@lagoncalvesjr
Copy link
Contributor

Apparently, it is all fine @AlejandroCornejo . But it is failing in one of the compilation tests

@roigcarlo
Copy link
Member

@lagoncalvesjr you can ignore win until I fix it, is a problem in the CI

@AlejandroCornejo AlejandroCornejo merged commit 6a5efa2 into master Jul 13, 2024
9 of 11 checks passed
@AlejandroCornejo AlejandroCornejo deleted the solve-restart-contact-structural-mech branch July 13, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants