Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Move unit tests to suite without kernel to improve performance #12541

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Jul 15, 2024

📝 Description
This PR moves 216 unit tests from a test suite with kernel to a kernel-less version. These move tests run within ~1 ms instead of 50-100 ms, improving performance of running the UT suite.

These were the low hanging-fruit tests that were movable with no changes to the test code. For the other tests, there are some slightly more involved steps to take.

@rfaasse rfaasse added Testing Performance GeoMechanics Issues related to the GeoMechanicsApplication labels Jul 15, 2024
@rfaasse rfaasse self-assigned this Jul 15, 2024
@rfaasse rfaasse requested a review from avdg81 July 15, 2024 08:48
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement that will benefit the entire team. Thanks for having taken the time to look into this and to significantly speed up the suite of unit tests.

@rfaasse rfaasse enabled auto-merge (squash) July 15, 2024 10:09
@rfaasse rfaasse merged commit 8e61a84 into master Jul 15, 2024
9 of 11 checks passed
@rfaasse rfaasse deleted the geo/move-tests-to-suite-without-kernel branch July 15, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication Performance Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants