[Core][MappingApplication] Make MapperFactory use Registry #12542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
changed the title
loumalouomega
added
Kratos Core
Applications
Refactor
There was a problem hiding this comment.
Okay from my side, maybe we should wait for @philbucher approval
philbucher
previously approved these changes
Jul 15, 2024
Comment on lines
+168
to
+170
| return std::string("mappers.all.mpi"); | ||
| } | ||
| return std::string("mappers.all"); |
There was a problem hiding this comment.
those names are only internally used in the registry right? I.e. nothing the user has to deal with?
There was a problem hiding this comment.
The users of MapperFactory should be able to continue interacting with it as usual. One could get the mappers directly form the registry using those paths, but this is not used at the moment.
|
Sorry, I forgot to remove some debug messages |
philbucher
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Refactoring the MapperFactory in order to use the Registry infrastructure instead of its internal registered_mappers list.
The motivation for the change is related to the new gtests and the need to load application dependencies dynamically. Consider a test suite that loads MappingApplication as a runtime dependency (because the tested application does not have compile-time dependencies to it and does not link to it)
3.1 Mappers registered in MapperFactory on each test start (when the test suite imports its dependencies in the kernel)
3.2 Test run
3.3 Applications de-registered
If the MapperFactory uses the registry instead, mappers are automatically registered when MapperApplication is de-registered in 3.3, so the deallocation in 5 is no longer a problem.
🆕 Changelog