[GeoMechanicsApplication] Cleaned up "geo" truss and cable elements #12543
Conversation
By removing the duplicated code it becomes clear what the cable element does in addition to what the truss element (its base class) does.
Effectively, the `override` was never executed, since the one and only derived class provided its own `override` that does not reference the one of the base class.
Previously, the default implementation was overridden by all derived classes (and it was not explicitly referenced from anywhere else). To make clear the code was never executed, it has now been replaced by throwing an exception.
These elements were untested. For truss elements in 3D models, we can use the truss element of StructuralMechanicsApplication. For truss elements in plane strain models, we need to investigate their need first.
The moved member functions were only used by the derived class. This is to prepare for the removal of the base class.
This is to prepare for the removal of the base class.
The moved member functions were only used by the derived class. This is to prepare for the removal of the base class.
The moved member functions were only used by the derived class. This is to prepare for the removal of the base class.
This is to prepare for the removal of `GeoTrussElementLinearBase`. It is no longer needed, since `GeoLinearTrussElement` was the only class that was derived from it.
The class had become redundant and it was no longer referenced.
- Applied the rule of zero by removing an explicitly defined destructor. - Removed an empty statement.
There was a problem hiding this comment.
This is a nicely scoped clean-up and removes quite some duplication. I checked that the implementations of the derived classes are identical now that some of the structure has changed.
I only have a single question about if there might be more possibilities to clean-up the cable, but I leave it up to you if that is worth it, or if we just rely on the new way of doing reset displacement (since that should just work out of the box with the cable) and remove it after.
| } | ||
|
|
||
| BaseType::CreateElementStiffnessMatrix(rLocalStiffnessMatrix, rCurrentProcessInfo); |
There was a problem hiding this comment.
This clarifies a lot indeed, do you think this is possible for other functions in the class as well?
There was a problem hiding this comment.
Good point. I did not check that, but I can imagine there are more such functions. I would suggest to investigate that separately and to create a new PR when needed.
📝 Description
Eliminated an unnecessary intermediate base class to make the element class hierarchy simpler. Also removed some duplicated code and fixed a few problems that were found by our code quality tools.
🆕 Changelog
GeoTrussElementLinearBase. ClassGeoLinearTrussElementnow has classGeoTrussElementBaseas its base class.GeoTrussElementLinearBaseto classGeoLinearTrussElement.GeoLinearTrussElementto follow the rule of zero.private(which used to beprotected).virtualmember functionUpdateInternalForces(of classGeoTrussElementBase) now throws an exception. The previous implementation was overridden by both derived classes and it also wasn't called directly. As a result, the code was never run. To express more clearly that the default implementation is not supposed to be used, it now throws an exception.