[GeoMechanicsApplication] ApplyConstantPhreaticMultiLinePressureProcess checks size of coordinates #12578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markelov208
approved these changes
Jul 26, 2024
Comment on lines
81
to
83
| if (!std::is_sorted(HorizontalDirectionCoordinates().begin(), HorizontalDirectionCoordinates().end())) { | ||
| KRATOS_ERROR << "The Horizontal Elements Coordinates are not ordered." << rParameters << std::endl; | ||
| } |
There was a problem hiding this comment.
What do you think, perhaps, it is nice to use KRATOS_ERROR_IF here and above? Everything will be in the same style. Please, put is_sorted check below next checks.
mnabideltares
approved these changes
Jul 29, 2024
mnabideltares
deleted the
geo/12577-ApplyConstantPhreaticMultiLinePressureProcess-checks-size-of-positions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When an instance of class
ApplyConstantPhreaticMultiLinePressureProcessis created, at least two coordinates must be supplied for both the gravity direction and the horizontal direction. Each direction is indicated by a zero-based index: 0 ->x_coordinates, 1 ->y_coordinates, and 2 ->z_coordinates. When there are too few coordinates supplied, an exception is thrown.