[FastPR][Core] Remove mesh_id warnings from AssignVectorByDirection processes #12581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenzorrilla
added
Cleanup
Kratos Core
Deprecated
FastPR
|
Can you check why pipelies fail?. then I will approve |
Because some tests are deliberately adding it... I'd remove it from there. |
loumalouomega
previously approved these changes
Jul 29, 2024
|
Note that I removed the backwards compatibility handler, which has been in there for around six months. |
It is Okay |
philbucher
previously approved these changes
Jul 29, 2024
Unfortunately there is no plan in this regard... I just came across with these ones and stepped up to remove them. |
rubenzorrilla
dismissed stale reviews from philbucher and loumalouomega
via
a174162
|
Sorry guys @loumalouomega @philbucher , I missed one... |
philbucher
approved these changes
Jul 29, 2024
rubenzorrilla
deleted the
core/mesh-id-warnings-assign-by-direction-processes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Remove the deprecated
mesh_idfrom the defaults of these processes. Note that the backwards compatibility is handled in the parent class. Indeed, the defaults of these processes were always adding themesh_idto be then removed in the parent class by the backwards compatibility handler (with the annoying warning message).