[OptApp] Use Response Expressions in the opt app #12582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
optapp/responses/arithmetic_operators
to
master
August 5, 2024 15:01
Igarizza
reviewed
Aug 5, 2024
| "response_name": "", | ||
| "type" : "", | ||
| "ref_value" : "initial_value" | ||
| "response_expression": "", |
There was a problem hiding this comment.
I don't understand why do you need this changes. we can discuss later
There was a problem hiding this comment.
Now, it is not only the name of the response which is accepted, it accepts a resposne expression. Thats the reason why i changed it. This is backward compatible. (I added a deprecation warning)
…e_arithmetic_operators
Igarizza
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR enables use of response expressions in the opt app. This replaces
response_namein the algorithms toresponse_expressionwhich enables giving an expression or a name. The following is accepted in any place (objective/constraint) in any algorithm.🆕 Changelog
ResponseRoutineto use the response expressions