[OptApp] Refactor the Optimization Problem #12589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunethwarna
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Thanks @Igarizza . I would implement the followings:
OptimizationProblem::Get/Has/RemoveResponseRoutinemethods andGetListOfResonseRoutinemethodOptimizationProblem::Get/Has/RemoveMasterControlmethods andGetListOfMasterControlsmethod- Need to change function signatures in
OptimizationProblemto addResponseRoutineandMasterControlfor python hinting support
to be consistent.
applications/OptimizationApplication/python_scripts/algorithms/algorithm_steepest_descent.py
Outdated
Show resolved
Hide resolved
Done! |
added 2 commits
July 30, 2024 14:22
applications/OptimizationApplication/python_scripts/utilities/optimization_problem.py
Show resolved
Hide resolved
sunethwarna
approved these changes
Aug 4, 2024
Igarizza
dismissed stale reviews from talhah-ansari and sunethwarna
via
09b2bb0
sunethwarna
previously approved these changes
Aug 16, 2024
added 2 commits
August 29, 2024 09:38
…rout_master_contr_to_opt_problem
talhah-ansari
approved these changes
Aug 29, 2024
Igarizza
deleted the
optapp/adding_resp_rout_master_contr_to_opt_problem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Refactoring Optimization problem to avoid circular import issue. PR adds ResponseRoutine and MasterControl to the OptimizationProblem to simplifies access to their components.
Please mark the PR with appropriate tags:
🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.