[SIAPP]Reverting P norm PR #12633
Merged
[SIAPP]Reverting P norm PR #12633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talhah-ansari
previously approved these changes
Aug 16, 2024
sunethwarna
reviewed
Aug 30, 2024
applications/SystemIdentificationApplication/tests/test_damage_response.py
Outdated
Show resolved
Hide resolved
applications/SystemIdentificationApplication/tests/test_damage_response.py
Outdated
Show resolved
Hide resolved
applications/SystemIdentificationApplication/tests/test_damage_response.py
Outdated
Show resolved
Hide resolved
...ns/SystemIdentificationApplication/custom_sensors/measurement_residual_response_function.cpp
Outdated
Show resolved
Hide resolved
sunethwarna
reviewed
Aug 30, 2024
...ns/SystemIdentificationApplication/custom_sensors/measurement_residual_response_function.cpp
Outdated
Show resolved
Hide resolved
...ns/SystemIdentificationApplication/custom_sensors/measurement_residual_response_function.cpp
Outdated
Show resolved
Hide resolved
...ns/SystemIdentificationApplication/custom_sensors/measurement_residual_response_function.cpp
Outdated
Show resolved
Hide resolved
sunethwarna
reviewed
Aug 30, 2024
| const double current_sensor_error = sensor_value - p_sensor->GetValue(SENSOR_MEASURED_VALUE); | ||
| p_sensor->SetValue(SENSOR_ERROR, current_sensor_error); | ||
| sum_B_p += ( std::pow( 0.5 * pow(current_sensor_error, 2) * p_sensor->GetWeight(), mPCoefficient ) ); | ||
| value += p_sensor->GetWeight() * std::pow(sensor_value - p_sensor->GetValue(SENSOR_MEASURED_VALUE), 2) * 0.5; |
There was a problem hiding this comment.
why do you need the value here? is it used anywhere?
There was a problem hiding this comment.
testing p=1 and old code
Comment on lines
9
to
10
| // Main authors: Suneth Warnakulasuriya, | ||
| // Ihar Antonau |
There was a problem hiding this comment.
You can put your name also here :)
applications/SystemIdentificationApplication/tests/responses/auxiliary_files/sensor_data.json
Outdated
Show resolved
Hide resolved
| "weight" : 1.0, | ||
| "variable_data": {} | ||
| }"""), | ||
| Kratos.Parameters("""{ |
There was a problem hiding this comment.
Are the sensors duplicated?
There was a problem hiding this comment.
yes, with different coord.
talhah-ansari
previously approved these changes
Sep 5, 2024
added 2 commits
September 5, 2024 13:15
talhah-ansari
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Due to some bug in the P norm gradient calculation in the parallel execution, I have reverted the code of the measurement_response back to the origin. I will debug and fix it later. This is the temporal solution.
🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.