[GeoMechanicsApplication] Create documentation for the new line interface geometry #12647

rfaasse · 2024-08-26T09:29:54Z

No description provided.

WPK4FEM

Thank you for the good start of documentation for interfaces. Not much to complain about. The documentation may grow as point or plane interfaces and diff-order interfaces are added.

WPK4FEM · 2024-08-26T11:00:27Z

applications/GeoMechanicsApplication/custom_geometries/2Plus2NodedLineGeometry.svg

Nice pictures! Maybe wise to indicate the \xi axis here (with origin in the middle of the mid-geometry.
Another question is how we clarify that this is 2 dimensional geometry.

I added the $\xi$ axis and an xy indication, I think that should do it.

WPK4FEM · 2024-08-26T11:06:22Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+## Line Interface Geometry
+The Line Interface Geometry is a custom geometry that can be used to define a line interface between two different domains. 
+
+The geometry is defined by two lines, one on each side of the interface, where they can connect to the larger body of the domains separated by the interface. Most calculations are performed on the 'midline', which is defined by the midpoints of the two lines. They are depicted as the grey lines in the figures below. Meaning that if a certain property is queried at a certain position, the call is forwarded to the underlying midline geometry. 


The first sentence is quite complex and with many comma's. I suggest make the last part a separate sentence. The lines connect to other model parts, that not necessarily are "larger bodies". ( you can also connect a line to a body using an interface. The line then still is "smaller" than the interface.

Done, let me know if this was what you meant!

mnabideltares

@rfaasse
Thank for for the documentation., I have just few minor comments

mnabideltares · 2024-08-26T11:04:23Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+
+![3Plus3NodedGeometry](3Plus3NodedLineGeometry.svg)
+
+One thing to note, is that this line interface geometry does not implement functions from the Geometry base class which are related to the integration scheme. That is because most of the time, interface geometries are used with a Lobatto integration scheme, which is not supported by the Geometry base class.


It needs to be mentioned that this geometry is not independent, and it is based on line geometry of 2d_2n, and 2d_3n, which are available in the core

Good point, I added links to the line_2d_2.h and line_2d_3.h files.

mnabideltares · 2024-08-26T11:05:49Z

applications/GeoMechanicsApplication/custom_geometries/README.md

@@ -0,0 +1,18 @@
+# Custom Geometries
+Geometries are responsible for calculating several geometric properties, such as the normal vector, shape function values at a given position and the (inverse/determinant of the) Jacobian. This folder contains custom geometries that are used in the GeoMechanicsApplication.


As far as I remember, the inverse of jacobian is not defined for this geometry!

Indeed, for our geometry, the inverse is not defined. This first part is a short intro on geometries in general (which could have them defined). Do you think we should mention explicitly here that the inverse of the jacobian is not implemented for the interface (because it isn't for the underlying lines?)

I think it is not necessary to mention that the inverse Jacobian is not calculated/defined for this geometry. It is too much details. So, maybe it is good to leave the text as it is.

mnabideltares · 2024-08-26T11:10:52Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+At this point, the 2+2 and 3+3 line interface geometries are implemented.
+When creating The 2+2 line interface geometry (by inputting 4 nodes), the following node numbering is used:
+
+![2Plus2NodedGeometry](2Plus2NodedLineGeometry.svg)


Needs to define the local coordinate in the picture

Agreed, done

I think x-y is irrelevant here. It is in xi , one dimensional local coordinate(s).

rfaasse

Thanks for the quick review, I processed the comments, let me know if this is what you had in mind.

rfaasse · 2024-08-26T11:28:14Z

applications/GeoMechanicsApplication/custom_geometries/README.md

@@ -0,0 +1,18 @@
+# Custom Geometries
+Geometries are responsible for calculating several geometric properties, such as the normal vector, shape function values at a given position and the (inverse/determinant of the) Jacobian. This folder contains custom geometries that are used in the GeoMechanicsApplication.


Indeed, for our geometry, the inverse is not defined. This first part is a short intro on geometries in general (which could have them defined). Do you think we should mention explicitly here that the inverse of the jacobian is not implemented for the interface (because it isn't for the underlying lines?)

rfaasse · 2024-08-26T11:29:15Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+
+![3Plus3NodedGeometry](3Plus3NodedLineGeometry.svg)
+
+One thing to note, is that this line interface geometry does not implement functions from the Geometry base class which are related to the integration scheme. That is because most of the time, interface geometries are used with a Lobatto integration scheme, which is not supported by the Geometry base class.


Good point, I added links to the line_2d_2.h and line_2d_3.h files.

rfaasse · 2024-08-26T11:42:56Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+## Line Interface Geometry
+The Line Interface Geometry is a custom geometry that can be used to define a line interface between two different domains. 
+
+The geometry is defined by two lines, one on each side of the interface, where they can connect to the larger body of the domains separated by the interface. Most calculations are performed on the 'midline', which is defined by the midpoints of the two lines. They are depicted as the grey lines in the figures below. Meaning that if a certain property is queried at a certain position, the call is forwarded to the underlying midline geometry. 


Done, let me know if this was what you meant!

rfaasse · 2024-08-26T11:59:19Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+At this point, the 2+2 and 3+3 line interface geometries are implemented.
+When creating The 2+2 line interface geometry (by inputting 4 nodes), the following node numbering is used:
+
+![2Plus2NodedGeometry](2Plus2NodedLineGeometry.svg)


Agreed, done

rfaasse · 2024-08-26T12:04:09Z

applications/GeoMechanicsApplication/custom_geometries/2Plus2NodedLineGeometry.svg

I added the $\xi$ axis and an xy indication, I think that should do it.

mnabideltares

@rfaasse
Thank you for adressing the review points. I still have few minor suggestions

mnabideltares · 2024-08-26T12:15:55Z

applications/GeoMechanicsApplication/custom_geometries/README.md

@@ -0,0 +1,18 @@
+# Custom Geometries
+Geometries are responsible for calculating several geometric properties, such as the normal vector, shape function values at a given position and the (inverse/determinant of the) Jacobian. This folder contains custom geometries that are used in the GeoMechanicsApplication.


I think it is not necessary to mention that the inverse Jacobian is not calculated/defined for this geometry. It is too much details. So, maybe it is good to leave the text as it is.

mnabideltares · 2024-08-26T12:21:47Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+At this point, the 2+2 and 3+3 line interface geometries are implemented.
+When creating The 2+2 line interface geometry (by inputting 4 nodes), the following node numbering is used:
+
+![2Plus2NodedGeometry](2Plus2NodedLineGeometry.svg)


I think x-y is irrelevant here. It is in xi , one dimensional local coordinate(s).

mnabideltares · 2024-08-26T12:24:46Z

applications/GeoMechanicsApplication/custom_geometries/README.md

+
+Similarly, the 3+3 line interface geometry has the following node numbering for its six nodes:
+
+![3Plus3NodedGeometry](3Plus3NodedLineGeometry.svg)


It is more clear if the length is mentioned here, namely -1 to +1. However, as it is a dependent geometry, maybe a full picture is needs in the original geometry. So, I leave it up to you!!!

WPK4FEM

Good to go for me.

mnabideltares

Ok to me

…face geometry (#12647)

rfaasse added 3 commits August 23, 2024 17:11

First start for the documentation of the line interface geometry

f69efa8

Added some extra space

986b463

Made a couple clarifications in the documentation

9be3bd6

rfaasse linked an issue Aug 26, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Create documentation for the new line interface geometry #12644

Closed

rfaasse requested review from WPK4FEM and mnabideltares August 26, 2024 10:56

WPK4FEM reviewed Aug 26, 2024

View reviewed changes

mnabideltares requested changes Aug 26, 2024

View reviewed changes

rfaasse added 2 commits August 26, 2024 14:05

Processing review comments

9e636bb

Committed missed change to 3+3 schematic

7d4a23b

rfaasse commented Aug 26, 2024

View reviewed changes

mnabideltares requested changes Aug 26, 2024

View reviewed changes

Processing review comments for schematics

c0b2117

WPK4FEM approved these changes Aug 27, 2024

View reviewed changes

mnabideltares approved these changes Aug 27, 2024

View reviewed changes

rfaasse merged commit ea016ff into master Aug 27, 2024
9 of 11 checks passed

rfaasse deleted the geo/12644-create-documentation-for-the-new-line-interface-geometry branch August 27, 2024 07:57

loumalouomega pushed a commit that referenced this pull request Aug 28, 2024

[GeoMechanicsApplication] Create documentation for the new line inter…

25c4f9b

…face geometry (#12647)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Create documentation for the new line interface geometry #12647

[GeoMechanicsApplication] Create documentation for the new line interface geometry #12647

rfaasse commented Aug 26, 2024

WPK4FEM left a comment

WPK4FEM Aug 26, 2024

rfaasse Aug 26, 2024

WPK4FEM Aug 26, 2024

rfaasse Aug 26, 2024

mnabideltares left a comment

mnabideltares Aug 26, 2024

rfaasse Aug 26, 2024

mnabideltares Aug 26, 2024

rfaasse Aug 26, 2024

mnabideltares Aug 26, 2024

mnabideltares Aug 26, 2024

rfaasse Aug 26, 2024

mnabideltares Aug 26, 2024

rfaasse left a comment

rfaasse Aug 26, 2024

rfaasse Aug 26, 2024

rfaasse Aug 26, 2024

rfaasse Aug 26, 2024

rfaasse Aug 26, 2024

mnabideltares left a comment

mnabideltares Aug 26, 2024

mnabideltares Aug 26, 2024

mnabideltares Aug 26, 2024

WPK4FEM left a comment

mnabideltares left a comment


		![3Plus3NodedGeometry](3Plus3NodedLineGeometry.svg)

		One thing to note, is that this line interface geometry does not implement functions from the Geometry base class which are related to the integration scheme. That is because most of the time, interface geometries are used with a Lobatto integration scheme, which is not supported by the Geometry base class.

		@@ -0,0 +1,18 @@
		# Custom Geometries
		Geometries are responsible for calculating several geometric properties, such as the normal vector, shape function values at a given position and the (inverse/determinant of the) Jacobian. This folder contains custom geometries that are used in the GeoMechanicsApplication.


		Similarly, the 3+3 line interface geometry has the following node numbering for its six nodes:

		![3Plus3NodedGeometry](3Plus3NodedLineGeometry.svg)

[GeoMechanicsApplication] Create documentation for the new line interface geometry #12647

[GeoMechanicsApplication] Create documentation for the new line interface geometry #12647

Conversation

rfaasse commented Aug 26, 2024

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnabideltares left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnabideltares left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

mnabideltares left a comment

Choose a reason for hiding this comment