[GeoMechanicsApplication] Move more unit tests to the suite without kernel #12661
Conversation
…-suite-without-kernel
…-suite-without-kernel
applications/GeoMechanicsApplication/tests/cpp_tests/test_Pw_normal_flux_condition.cpp
Outdated
Show resolved
Hide resolved
| if (DimensionSize == 2 && node_ids.size() == 3) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<2, 3>>( | ||
| 1, Kratos::make_shared<Line2D3<Node>>(node_pointers), pProperties); | ||
| } | ||
| if (DimensionSize == 2 && node_ids.size() == 4) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<2, 4>>( | ||
| 1, Kratos::make_shared<Line2D4<Node>>(node_pointers), pProperties); | ||
| } | ||
| if (DimensionSize == 2 && node_ids.size() == 5) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<2, 5>>( | ||
| 1, Kratos::make_shared<Line2D5<Node>>(node_pointers), pProperties); | ||
| } | ||
| if (DimensionSize == 3 && node_ids.size() == 3) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<3, 3>>( | ||
| 1, Kratos::make_shared<Triangle3D3<Node>>(node_pointers), pProperties); | ||
| } | ||
| if (DimensionSize == 3 && node_ids.size() == 6) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<3, 6>>( | ||
| 1, Kratos::make_shared<Triangle3D6<Node>>(node_pointers), pProperties); | ||
| } | ||
| if (DimensionSize == 3 && node_ids.size() == 4) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<3, 4>>( | ||
| 1, Kratos::make_shared<Quadrilateral3D4<Node>>(node_pointers), pProperties); | ||
| } | ||
| if (DimensionSize == 3 && node_ids.size() == 8) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<3, 8>>( | ||
| 1, Kratos::make_shared<Quadrilateral3D8<Node>>(node_pointers), pProperties); | ||
| } | ||
| if (DimensionSize == 3 && node_ids.size() == 9) { | ||
| condition = make_intrusive<GeoTMicroClimateFluxCondition<3, 9>>( | ||
| 1, Kratos::make_shared<Quadrilateral3D9<Node>>(node_pointers), pProperties); | ||
| } |
There was a problem hiding this comment.
Since these checks should be mutually exclusive, I would suggest to use else if for any subsequent checks.
| rModelPart.AddCondition(condition); | ||
| return condition; | ||
| } | ||
|
|
||
| return rModelPart.CreateNewCondition(condition_name, condition_id, node_ids, pProperties); |
There was a problem hiding this comment.
Just for my understanding: if none of the above combinations of dimension and number of nodes applies, we would end up here, resulting in an error (because there is no kernel available)?
There was a problem hiding this comment.
Yes, I will remove this line actually, because it doesn't make sense to keep this 'fallback'
| for (auto node_id : node_ids) { | ||
| node_pointers.emplace_back(rModelPart.pGetNode(node_id)); | ||
| } |
There was a problem hiding this comment.
This could be written as a std::transform, or not...?
There was a problem hiding this comment.
Yes, done! I had some trouble finding the correct iterators, but then remembered the ptr_begin()
| class StubConstitutiveLaw : public ConstitutiveLaw | ||
| { | ||
| }; |
There was a problem hiding this comment.
As far as I can see, this class is not being used. If that is correct, please remove it.
There was a problem hiding this comment.
You're right, removed!
| @@ -79,7 +80,10 @@ namespace Kratos::Testing | |||
|
|
|||
| // Create the test piping element | |||
| std::vector<ModelPart::IndexType> element_nodes{1, 2, 3, 4}; | |||
There was a problem hiding this comment.
element_nodes appears to be no longer in use, so please remove it.
There was a problem hiding this comment.
Good catch, removed!
| @@ -152,7 +152,10 @@ namespace Kratos::Testing | |||
|
|
|||
| // Create the test piping element | |||
| std::vector<ModelPart::IndexType> element_nodes{1, 2, 3, 4}; | |||
There was a problem hiding this comment.
Also here, element_nodes appears to be no longer in use.
There was a problem hiding this comment.
Good catch, removed!
| auto transient_thermal_element = make_intrusive<TransientThermalElement<2, 3>>( | ||
| 1, Kratos::make_shared<Triangle2D3<Node>>(nodes)); | ||
|
|
||
| return transient_thermal_element; |
There was a problem hiding this comment.
Just for my understanding: the reason you don't add the element to the model part here is because it would throw an exception, since the Check operation fails...?
There was a problem hiding this comment.
I don't because we don't need a model part here, so I just create the element without a model part
…-suite-without-kernel
Moved all tests which were movable with reasonable effort to the kernel-less suite. This saves ~100-200 ms per moved test every time we run the unit tests. On my local machine in debug, this reduces the time to run these unit tests from ~15 sec to ~5 sec.